Re: clockevents: fix resume logic

Thomas Gleixner
2007-09-11T07:23:34Z

On Tue, 2007-09-11 at 00:00 -0700, Andrew Morton wrote:
> > > This patch broke the jinxed vaio.
> > >
> > > Which is a bit odd, considering that I must have tested it at the time.
> > > But I bisected it right down to this commit, and the below revert patch
> > > fixed it up.
> >
> > I just looked up, that you confirmed earlier that the patch does _not_
> > break the VAIO.
> >
> > I think, that some other suspend/resume/ACPI or whatever change went in
> > before this patch got merged into Linus tree. Sigh. That's pretty hard
> > to find out.
> >
>
> I tried just 18de5bc4c1f1f1fa5e14f354a7603bd6e9d4e3b6 on top of 2.6.22
> (threw away the lguest and xen hunks). The same problem occurs. 2.6.22 is
> OK.

Hmm.

> I went back to the original patch which I sent to Linus and it matches
> 18de5bc4c1f1f1fa5e14f354a7603bd6e9d4e3b6. So all I can think is that there
> must have been something else in the tree which I tested which fixed the
> bug which 18de5bc4c1f1f1fa5e14f354a7603bd6e9d4e3b6 introduced. argh.
>
> Can you think what would cause the symptoms which I described?

It seems that time is not updated. Timer interrupt not active or some
other odd thing. I figure out what's going on when I find a box which
exposes the problem.

tglx