Re: clockevents: fix resume logic

Andrew Morton
2007-09-11T10:32:26Z

On Tue, 11 Sep 2007 11:16:04 +0200 Thomas Gleixner <tglx@linutronix.de> wrote:

> On Tue, 2007-09-11 at 01:35 -0700, Andrew Morton wrote:
> > On Tue, 11 Sep 2007 01:20:05 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > > On Tue, 11 Sep 2007 09:47:20 +0200 Thomas Gleixner <tglx@linutronix.de> wrote:
> > >
> > > > On Tue, 2007-09-11 at 09:23 +0200, Thomas Gleixner wrote:
> > > > > > I went back to the original patch which I sent to Linus and it matches
> > > > > > 18de5bc4c1f1f1fa5e14f354a7603bd6e9d4e3b6. So all I can think is that there
> > > > > > must have been something else in the tree which I tested which fixed the
> > > > > > bug which 18de5bc4c1f1f1fa5e14f354a7603bd6e9d4e3b6 introduced. argh.
> > > > > >
> > > > > > Can you think what would cause the symptoms which I described?
> > > > >
> > > > > It seems that time is not updated. Timer interrupt not active or some
> > > > > other odd thing. I figure out what's going on when I find a box which
> > > > > exposes the problem.
> > >
> > > 2.6.22-rc6-mm1's git-acpi.patch contains something which fixes this bug.
> >
> > Len's current tree fixes it too. Maybe we just need to merge the acpi tree?
>
> Did you enable CONFIG_CPU_IDLE after you applied git-acpi to rc6 ?
>

Nope.

Anyway, I've had it. git seems a bit weird when it's trying to bisect down
to a point where code started to work correctly, rather than finding when
it failed (I just reversed "good" and "bad"). The acpi tree is littered
with build errors at various points and I just don't know which patch fixed
it - git-bisect seems to keep turning up junk.

Ho hum. Maybe tomorrow I'll have a go at turning the acpi tree into a
series of flat patches and do it sanely.