Re: clockevents: fix resume logic

Andrew Morton
2007-09-12T09:14:34Z

On Tue, 11 Sep 2007 21:52:01 +0200 Thomas Gleixner <tglx@linutronix.de> wrote:

> On Tue, 2007-09-11 at 11:44 -0700, Andrew Morton wrote:
> > > > there doesn't seem to be a lot of difference in the time handling, except
> > > > there are large changes in when things happen in the bootup sequence.
> > >
> > > The question is whether the system goes into C2 with the patch applied.
> > >
> > > Can you please provide the output of /proc/acpi/processor/CPU0/power for
> > > both the bad and the good one ?
> > >
> >
> > good:
> >
> > sony:/home/akpm> cat /proc/acpi/processor/CPU0/power
> > active state: C0
> > max_cstate: C8
> > bus master activity: 00000000
> > maximum allowed latency: 8000 usec
> > states:
> > C1: type[C1] promotion[--] demotion[--] latency[001] usage[00000000] duration[00000000000000000000]
> > C2: type[C2] promotion[--] demotion[--] latency[001] usage[00000000] duration[00000000000000000000]
> >
> > bad:
> >
> > sony:/home/akpm> cat /proc/acpi/processor/CPU0/power
> > active state: C2
> > max_cstate: C8
> > bus master activity: 00000000
> > maximum allowed latency: 8000 usec
> > states:
> > C1: type[C1] promotion[C2] demotion[--] latency[001] usage[00000010] duration[00000000000000000000]
> > *C2: type[C2] promotion[--] demotion[C1] latency[001] usage[00008316] duration[00000000000170717293]
>
> Ok, here we are. The bad one uses C2 which stops the local apic on the
> VAIO. I suspect we end up in the suspend/resume with going into C2
> without the broadcast active.
>
> Can you try to get the output of SysRq-Q during the "it needs help from
> keyboard" period ?
>

That's a bit tricky because hitting the keyboard is what unsticks things.
And the video is black after resume-from-RAM (has always been thus) and we
broke netconsole-over-e100-during-resume back in 2.6.21 or thereabouts.

<struggles a bit>

Here: http://userweb.kernel.org/~akpm/x.txt