Re: clockevents: fix resume logic

Rafael J. Wysocki
2007-09-11T19:23:32Z

On Tuesday, 11 September 2007 20:25, Andrew Morton wrote:
> On Tue, 11 Sep 2007 14:09:12 +0200 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
>
> > On Tuesday, 11 September 2007 13:22, Andrew Morton wrote:
> > > On Tue, 11 Sep 2007 13:23:55 +0200 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> > >
> > > > On Tuesday, 11 September 2007 12:31, Andrew Morton wrote:
> > > > > On Tue, 11 Sep 2007 11:16:04 +0200 Thomas Gleixner <tglx@linutronix.de> wrote:
> > > > >
> > > > > > On Tue, 2007-09-11 at 01:35 -0700, Andrew Morton wrote:
> > > > > > > On Tue, 11 Sep 2007 01:20:05 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
> > > > > > >
> > > > > > > > On Tue, 11 Sep 2007 09:47:20 +0200 Thomas Gleixner <tglx@linutronix.de> wrote:
> > > > > > > >
> > > > > > > > > On Tue, 2007-09-11 at 09:23 +0200, Thomas Gleixner wrote:
> > > > > > > > > > > I went back to the original patch which I sent to Linus and it matches
> > > > > > > > > > > 18de5bc4c1f1f1fa5e14f354a7603bd6e9d4e3b6. So all I can think is that there
> > > > > > > > > > > must have been something else in the tree which I tested which fixed the
> > > > > > > > > > > bug which 18de5bc4c1f1f1fa5e14f354a7603bd6e9d4e3b6 introduced. argh.
> > > > > > > > > > >
> > > > > > > > > > > Can you think what would cause the symptoms which I described?
> > > > > > > > > >
> > > > > > > > > > It seems that time is not updated. Timer interrupt not active or some
> > > > > > > > > > other odd thing. I figure out what's going on when I find a box which
> > > > > > > > > > exposes the problem.
> > > > > > > >
> > > > > > > > 2.6.22-rc6-mm1's git-acpi.patch contains something which fixes this bug.
> > > > > > >
> > > > > > > Len's current tree fixes it too.
> > > >
> > > > Do you mean this one:
> > > >
> > > > http://git.kernel.org/?p=linux/kernel/git/lenb/linux-acpi-2.6.git
> > >
> > > Nope.
> > >
> > > Here's the algorthm: go to the latest -mm tree and look at the first line
> > > of broken-out/git-acpi.patch:
> > >
> > > GIT f94aac9883f9b02700270cf286577a9bccf98f47 git+ssh://master.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6.git#test
> > >
> > > that gives the URL, the branch and the top-level commit. All the -mm git
> > > trees have that first line.
> > >
> > >
> > >
> > > Anyway, I was able to extract all the diffs and generate a patch series.
> > > The below patch fixes current mainline on the Vaio.
> >
> > It evidently assumes cpuidle to be present, which is not in the mainline.
>
> Bear in mind that the cpuidle patch fixes resume-from-ram when cpuidle is
> disabled in config.
>
> > It seems to me that the total effect of this one and the hackpatch is that
> > the C states are not handled any more.
>
> hm.
>
> dmesg without the cpuidle patch: http://userweb.kernel.org/~akpm/dmesg-bad.txt
> dmesg with the cpuidle patch: http://userweb.kernel.org/~akpm/dmesg-good.txt
> difference: http://userweb.kernel.org/~akpm/dmesg-diff.txt
>
> there doesn't seem to be a lot of difference in the time handling, except
> there are large changes in when things happen in the bootup sequence.

Hm, these things look like they may be related to the suspend/resume problems:

+Marking TSC unstable due to: possible TSC halt in C2.

+Clocksource tsc unstable (delta = -458965792 ns)