Re: clockevents: fix resume logic

Andrew Morton
2007-09-11T18:45:27Z

On Tue, 11 Sep 2007 20:38:03 +0200 Thomas Gleixner <tglx@linutronix.de> wrote:

> On Tue, 2007-09-11 at 11:25 -0700, Andrew Morton wrote:
> > > It evidently assumes cpuidle to be present, which is not in the mainline.
> >
> > Bear in mind that the cpuidle patch fixes resume-from-ram when cpuidle is
> > disabled in config.
> >
> > > It seems to me that the total effect of this one and the hackpatch is that
> > > the C states are not handled any more.
> >
> > hm.
> >
> > dmesg without the cpuidle patch: http://userweb.kernel.org/~akpm/dmesg-bad.txt
> > dmesg with the cpuidle patch: http://userweb.kernel.org/~akpm/dmesg-good.txt
> > difference: http://userweb.kernel.org/~akpm/dmesg-diff.txt
> >
> > there doesn't seem to be a lot of difference in the time handling, except
> > there are large changes in when things happen in the bootup sequence.
>
> The question is whether the system goes into C2 with the patch applied.
>
> Can you please provide the output of /proc/acpi/processor/CPU0/power for
> both the bad and the good one ?
>

good:

sony:/home/akpm> cat /proc/acpi/processor/CPU0/power
active state: C0
max_cstate: C8
bus master activity: 00000000
maximum allowed latency: 8000 usec
states:
C1: type[C1] promotion[--] demotion[--] latency[001] usage[00000000] duration[00000000000000000000]
C2: type[C2] promotion[--] demotion[--] latency[001] usage[00000000] duration[00000000000000000000]

bad:

sony:/home/akpm> cat /proc/acpi/processor/CPU0/power
active state: C2
max_cstate: C8
bus master activity: 00000000
maximum allowed latency: 8000 usec
states:
C1: type[C1] promotion[C2] demotion[--] latency[001] usage[00000010] duration[00000000000000000000]
*C2: type[C2] promotion[--] demotion[C1] latency[001] usage[00008316] duration[00000000000170717293]