Re: clockevents: fix resume logic

Thomas Gleixner
2007-09-11T06:37:32Z

On Mon, 2007-09-10 at 14:47 -0700, Andrew Morton wrote:
> >
> > clockevents: fix resume logic
> >
> > We need to make sure, that the clockevent devices are resumed, before
> > the tick is resumed. The current resume logic does not guarantee this.
> >
> > Add CLOCK_EVT_MODE_RESUME and call the set mode functions of the clock
> > event devices before resuming the tick / oneshot functionality.
> >
> > Fixup the existing users.
> >
> > Thanks to Nigel Cunningham for tracking down a long standing thinko,
> > which affected the jinxed VAIO.
> >
>
> This patch broke the jinxed vaio.
>
> Which is a bit odd, considering that I must have tested it at the time.
> But I bisected it right down to this commit, and the below revert patch
> fixed it up.

I just looked up, that you confirmed earlier that the patch does _not_
break the VAIO.

I think, that some other suspend/resume/ACPI or whatever change went in
before this patch got merged into Linus tree. Sigh. That's pretty hard
to find out.

tglx