Re: [PATCH -mm] ssb: Make pcmciahost depend on PCMCIA=y

Paul Mundt
2007-09-13T01:43:59Z

On Wed, Sep 12, 2007 at 12:59:00PM +0200, Michael Buesch wrote:
> On Wednesday 12 September 2007 12:17:45 Paul Mundt wrote:
> > On Wed, Sep 12, 2007 at 12:09:09PM +0200, Michael Buesch wrote:
> > > There we go. The usual SELECT dependency hell again...
> > > Would changing SSB_PCMCIAHOST_POSSIBLE to tristate also fix it?
> > > What would be the sideeffects?
> > >
> > I tried that first, if you do that you have to change the default to
> > SSB && PCMCIA, and then anything that depends on it also has to be a
> > tristate. That worked ok for SSB_PCMCIAHOST, but it didn't work ok for
> > the b43 wireless + PCMCIA, which is why I opted for the PCMCIA=y thing
> > instead, which makes sure that SSB_PCMCIAHOST can't be enabled if PCMCIA
> > is modular.
>
> Ok, so much for "SELECT is easy and it works if used correctly..." :)
> Well, let's apply that patch then. It needlessly restricts the
> choice to not allow modular pcmcia in that case, though.
>
That is the compromise, yes. Feel free to propose a better solution ;-)