From: Randy Dunlap <randy.dunlap@oracle.com>
To: Matt Mackall <mpm@selenic.com>
Cc: Jiri Slaby <jirislaby@gmail.com>,
kgdb-bugreport@lists.sourceforge.net, amitkale@linsyssoft.com,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
jason.wessel@windriver.com,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH -mm v2] 2.6.23-rc4-mm1: kgdboe link errors
Date: Wed, 12 Sep 2007 11:22:52 -0700 [thread overview]
Message-ID: <20070912112252.7658b7db.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20070912181512.GQ4219@waste.org>
On Wed, 12 Sep 2007 13:15:12 -0500 Matt Mackall wrote:
> NETCONSOLE shouldn't be necessary. Otherwise this looks ok to my
> kconfig-addled brain.
Correct. Patch corrected. Thanks.
---
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix kgdb build problems:
Building modules, stage 2.
ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_parse_options" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_poll" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_send_udp" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_set_trap" [drivers/net/kgdboe.ko] undefined!
make[1]: *** [__modpost] Error 1
Add 'select' for net-poll related config symbols, but
make KGDBOE 'depend on' NET. We don't want to 'select' CONFIG_NET,
but if it is already enabled, the 'select's will enable the rest
of the needed interfaces.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
lib/Kconfig.kgdb | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-2.6.23-rc4-mm1.orig/lib/Kconfig.kgdb
+++ linux-2.6.23-rc4-mm1/lib/Kconfig.kgdb
@@ -174,9 +174,10 @@ endchoice
config KGDBOE
tristate "KGDB: On ethernet" if !KGDBOE_NOMODULE
- depends on m && KGDB
+ depends on m && KGDB && NET
select NETPOLL
select NETPOLL_TRAP
+ select NET_POLL_CONTROLLER
help
Uses the NETPOLL API to communicate with the host GDB via UDP.
In order for this to work, the ethernet interface specified must
next prev parent reply other threads:[~2007-09-12 18:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-12 9:31 2.6.23-rc4-mm1: kgdboe link errors Jiri Slaby
2007-09-12 17:15 ` [PATCH -mm] " Randy Dunlap
2007-09-12 18:15 ` Matt Mackall
2007-09-12 18:22 ` Randy Dunlap [this message]
2007-09-12 18:50 ` [PATCH -mm v2] " Matt Mackall
2007-09-12 19:17 ` [Kgdb-bugreport] " Jason Wessel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070912112252.7658b7db.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=amitkale@linsyssoft.com \
--cc=jason.wessel@windriver.com \
--cc=jirislaby@gmail.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox