From: Andi Kleen <ak@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Huang, Ying" <ying.huang@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [BUGFIX] x86_64: NX bit handling in change_page_attr
Date: Wed, 12 Sep 2007 15:35:31 +0200 [thread overview]
Message-ID: <200709121535.31550.ak@suse.de> (raw)
In-Reply-To: <20070911202332.c539f1fe.akpm@linux-foundation.org>
> > Index: linux-2.6.23-rc2-mm2/arch/x86_64/mm/pageattr.c
> > ===================================================================
> > --- linux-2.6.23-rc2-mm2.orig/arch/x86_64/mm/pageattr.c 2007-08-17
> > 12:50:25.000000000 +0800 +++
> > linux-2.6.23-rc2-mm2/arch/x86_64/mm/pageattr.c 2007-08-17
> > 12:50:48.000000000 +0800 @@ -147,6 +147,7 @@
> > split = split_large_page(address, prot, ref_prot2);
> > if (!split)
> > return -ENOMEM;
> > + pgprot_val(ref_prot2) &= ~_PAGE_NX;
> > set_pte(kpte, mk_pte(split, ref_prot2));
> > kpte_page = split;
> > }
>
> What happened with this? Still valid?
The bug is probably latent there, but I don't think it can affect anything
in the kernel because nothing in the kernel should change NX status
as far as I know.
Where did you see it?
Anyways I would prefer to only clear the PMD NX when NX status actually
changes on the PTE.Can you do that change?
Anyways; it's really not very important.
-Andi
next prev parent reply other threads:[~2007-09-12 13:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-17 5:28 [BUGFIX] x86_64: NX bit handling in change_page_attr Huang, Ying
2007-09-12 3:23 ` Andrew Morton
2007-09-12 6:18 ` Huang, Ying
2007-09-12 13:35 ` Andi Kleen [this message]
2007-09-13 1:12 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709121535.31550.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox