From: Yinghai Lu <Yinghai.Lu@Sun.COM>
To: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@suse.de>, Jeff Garzik <jeff@garzik.org>,
Greg KH <greg@kroah.com>, Martin Mares <mj@ucw.cz>,
dean gaudet <dean@arctic.org>,
Robert Richter <robert.richter@amd.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86_64: set cfg_size for AMD Family 10h in case MMCONFIG is used
Date: Wed, 12 Sep 2007 19:21:43 -0700 [thread overview]
Message-ID: <200709121921.43950.yinghai.lu@sun.com> (raw)
[PATCH] x86_64: set cfg_size for AMD Family 10h in case MMCONFIG is used.
reuse pci_cfg_space_size but skip check pci express and pci-x CAP ID.
Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
arch/i386/pci/fixup.c | 13 +++++++++++++
drivers/pci/probe.c | 11 ++++++++++-
include/linux/pci.h | 1 +
3 files changed, 24 insertions(+), 1 deletion(-)
===================================================================
Index: linux-2.6/arch/i386/pci/fixup.c
===================================================================
--- linux-2.6.orig/arch/i386/pci/fixup.c 2007-09-12 19:00:56.000000000 -0700
+++ linux-2.6/arch/i386/pci/fixup.c 2007-09-12 19:01:32.000000000 -0700
@@ -444,3 +444,16 @@
}
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SIEMENS, 0x0015,
pci_siemens_interrupt_controller);
+
+/**
+ * Regular PCI devices have 256 bytes, but AMD Family 10h Opteron ext config
+ * have 4096 bytes. Even if the device is capable, that doesn't mean we can
+ * access it. Maybe we don't have a way to generate extended config space
+ * accesses. So check it
+ */
+static void fam10h_pci_cfg_space_size(struct pci_dev *dev)
+{
+ dev->cfg_size = pci_cfg_space_size_ext(dev, 0);
+}
+
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_AMD, PCI_ANY_ID, fam10h_pci_cfg_space_size);
Index: linux-2.6/drivers/pci/probe.c
===================================================================
--- linux-2.6.orig/drivers/pci/probe.c 2007-09-12 19:00:56.000000000 -0700
+++ linux-2.6/drivers/pci/probe.c 2007-09-12 19:01:32.000000000 -0700
@@ -831,11 +831,14 @@
* reading the dword at 0x100 which must either be 0 or a valid extended
* capability header.
*/
-int pci_cfg_space_size(struct pci_dev *dev)
+int pci_cfg_space_size_ext(struct pci_dev *dev, unsigned check_exp_pcix)
{
int pos;
u32 status;
+ if (!check_exp_pcix)
+ goto skip;
+
pos = pci_find_capability(dev, PCI_CAP_ID_EXP);
if (!pos) {
pos = pci_find_capability(dev, PCI_CAP_ID_PCIX);
@@ -847,6 +850,7 @@
goto fail;
}
+ skip:
if (pci_read_config_dword(dev, 256, &status) != PCIBIOS_SUCCESSFUL)
goto fail;
if (status == 0xffffffff)
@@ -858,6 +862,11 @@
return PCI_CFG_SPACE_SIZE;
}
+int pci_cfg_space_size(struct pci_dev *dev)
+{
+ return pci_cfg_space_size_ext(dev, 1);
+}
+
static void pci_release_bus_bridge_dev(struct device *dev)
{
kfree(dev);
Index: linux-2.6/include/linux/pci.h
===================================================================
--- linux-2.6.orig/include/linux/pci.h 2007-09-12 19:00:56.000000000 -0700
+++ linux-2.6/include/linux/pci.h 2007-09-12 19:01:32.000000000 -0700
@@ -626,6 +626,7 @@
void pci_walk_bus(struct pci_bus *top, void (*cb)(struct pci_dev *, void *),
void *userdata);
+int pci_cfg_space_size_ext(struct pci_dev *dev, unsigned check_exp_pcix);
int pci_cfg_space_size(struct pci_dev *dev);
unsigned char pci_bus_max_busnr(struct pci_bus* bus);
next reply other threads:[~2007-09-13 2:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-13 2:21 Yinghai Lu [this message]
2007-09-13 2:17 ` [PATCH] x86_64: set cfg_size for AMD Family 10h in case MMCONFIG is used Andrew Morton
2007-09-13 9:47 ` Andi Kleen
2007-09-13 10:47 ` Greg KH
2007-09-13 11:53 ` Andi Kleen
2007-09-13 17:01 ` Yinghai Lu
2007-09-13 17:20 ` H. Peter Anvin
2007-09-13 19:22 ` Yinghai Lu
2007-09-13 19:31 ` H. Peter Anvin
2007-09-13 20:15 ` Andreas Herrmann
2007-09-13 20:54 ` H. Peter Anvin
2007-09-14 11:21 ` [PATCH] x86_64: set cfg_size for AMD Family 10h in case MMCONFIG Andreas Herrmann
2007-09-14 14:08 ` H. Peter Anvin
2007-09-14 17:28 ` Yinghai Lu
2007-09-14 18:09 ` Yinghai Lu
2007-09-16 3:18 ` [PATCH] x86_64: set cfg_size for AMD Family 10h in case MMCONFIG is used Andi Kleen
2007-09-13 19:52 ` Andreas Herrmann
2007-09-13 20:14 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709121921.43950.yinghai.lu@sun.com \
--to=yinghai.lu@sun.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dean@arctic.org \
--cc=greg@kroah.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mj@ucw.cz \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox