From: Jeff Dike <jdike@addtoit.com>
To: Andrew Morton <akpm@osdl.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: [PATCH 1/11] UML - Eliminate hz()
Date: Wed, 12 Sep 2007 17:16:44 -0400 [thread overview]
Message-ID: <20070912211644.GA10231@c2.user-mode-linux.org> (raw)
Eliminate hz() since its only purpose was to provide a kernel-space
constant to userspace code. This can be done instead by providing the
constant directly through kernel_constants.h.
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
--
arch/um/include/common-offsets.h | 2 ++
arch/um/include/kern_util.h | 1 -
arch/um/kernel/time.c | 5 -----
arch/um/os-Linux/skas/process.c | 5 +++--
arch/um/os-Linux/time.c | 7 +++----
5 files changed, 8 insertions(+), 12 deletions(-)
Index: linux-2.6.22/arch/um/include/common-offsets.h
===================================================================
--- linux-2.6.22.orig/arch/um/include/common-offsets.h 2007-08-30 21:27:32.000000000 +0100
+++ linux-2.6.22/arch/um/include/common-offsets.h 2007-08-30 21:30:13.000000000 +0100
@@ -32,3 +32,5 @@ DEFINE(UM_GFP_ATOMIC, GFP_ATOMIC);
DEFINE(crypto_tfm_ctx_offset, offsetof(struct crypto_tfm, __crt_ctx));
DEFINE(UM_THREAD_SIZE, THREAD_SIZE);
+
+DEFINE(UM_HZ, HZ);
Index: linux-2.6.22/arch/um/include/kern_util.h
===================================================================
--- linux-2.6.22.orig/arch/um/include/kern_util.h 2007-08-30 21:27:33.000000000 +0100
+++ linux-2.6.22/arch/um/include/kern_util.h 2007-08-30 21:30:13.000000000 +0100
@@ -64,7 +64,6 @@ extern void paging_init(void);
extern void init_flush_vm(void);
extern void *syscall_sp(void *t);
extern void syscall_trace(struct uml_pt_regs *regs, int entryexit);
-extern int hz(void);
extern unsigned int do_IRQ(int irq, struct uml_pt_regs *regs);
extern void interrupt_end(void);
extern void initial_thread_cb(void (*proc)(void *), void *arg);
Index: linux-2.6.22/arch/um/kernel/time.c
===================================================================
--- linux-2.6.22.orig/arch/um/kernel/time.c 2007-08-30 21:27:32.000000000 +0100
+++ linux-2.6.22/arch/um/kernel/time.c 2007-09-02 19:01:28.000000000 +0100
@@ -11,11 +11,6 @@
#include "kern_util.h"
#include "os.h"
-int hz(void)
-{
- return HZ;
-}
-
/*
* Scheduler clock - returns current time in nanosec units.
*/
Index: linux-2.6.22/arch/um/os-Linux/skas/process.c
===================================================================
--- linux-2.6.22.orig/arch/um/os-Linux/skas/process.c 2007-08-30 21:27:32.000000000 +0100
+++ linux-2.6.22/arch/um/os-Linux/skas/process.c 2007-09-02 19:01:28.000000000 +0100
@@ -392,8 +392,9 @@ int copy_context_skas0(unsigned long new
*data = ((struct stub_data) { .offset = MMAP_OFFSET(new_offset),
.fd = new_fd,
.timer = ((struct itimerval)
- { { 0, 1000000 / hz() },
- { 0, 1000000 / hz() }})});
+ { { 0, 1000000 / UM_HZ },
+ { 0, 1000000 / UM_HZ }})
+ });
err = ptrace_setregs(pid, thread_regs);
if (err < 0)
panic("copy_context_skas0 : PTRACE_SETREGS failed, "
Index: linux-2.6.22/arch/um/os-Linux/time.c
===================================================================
--- linux-2.6.22.orig/arch/um/os-Linux/time.c 2007-08-30 21:27:32.000000000 +0100
+++ linux-2.6.22/arch/um/os-Linux/time.c 2007-09-02 19:01:28.000000000 +0100
@@ -8,14 +8,13 @@
#include <signal.h>
#include <time.h>
#include <sys/time.h>
-#include "kern_util.h"
#include "kern_constants.h"
#include "os.h"
#include "user.h"
int set_interval(int is_virtual)
{
- int usec = 1000000/hz();
+ int usec = 1000000/UM_HZ;
int timer_type = is_virtual ? ITIMER_VIRTUAL : ITIMER_REAL;
struct itimerval interval = ((struct itimerval) { { 0, usec },
{ 0, usec } });
@@ -43,8 +42,8 @@ void disable_timer(void)
void switch_timers(int to_real)
{
struct itimerval disable = ((struct itimerval) { { 0, 0 }, { 0, 0 }});
- struct itimerval enable = ((struct itimerval) { { 0, 1000000/hz() },
- { 0, 1000000/hz() }});
+ struct itimerval enable = ((struct itimerval) { { 0, 1000000/UM_HZ },
+ { 0, 1000000/UM_HZ }});
int old, new;
if (to_real) {
next reply other threads:[~2007-09-12 21:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-12 21:16 Jeff Dike [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-09-19 17:02 [PATCH 1/11] UML - Eliminate hz() Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070912211644.GA10231@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox