public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org,
	linux-usb-devel@lists.sourceforge.net,
	Alan Stern <stern@rowland.harvard.edu>,
	Oliver Neukum <oneukum@suse.de>
Subject: [GIT PATCH] USB autosuspend fixes for 2.6.23-rc6
Date: Thu, 13 Sep 2007 06:33:21 -0700	[thread overview]
Message-ID: <20070913133321.GA6362@kroah.com> (raw)

It turns out that USB devices suck when it comes to powermanagement
issues :(

A number of patches have been submitted near the end of this kernel
release cycle that add new device ids to the quirk table in the kernel
to disable autosuspend for specific devices.  However, a number of
developers are very worried that even with the testing that has been
done, once 2.6.23 is released, we are going to get a whole raft of angry
users when their devices break in nasty ways.

As an example, it seems that almost 2/3 of all USB printers just can not
handle autosuspend.  And there's a _lot_ of USB printers out there...

When researching how other operating systems handle this, it was found
out that they use a whitelist of devices that are able to properly
suspend.  So, in the future, that is how we are going to handle this.

These two patches address the need today to have users machines still
work, even if they might draw more power than they possibly could (which
is not any more than they did in 2.6.22.)

These patches do two things:
  - disable USB autosuspend on all devices except for USB hubs.  This
    can be easily overridden by userspace to turn on autosuspend for
    devices that a user wants to.  HAL will use a whitelist in the
    future for these types of devices.
  - revert the usb-storage autosuspend patch.  This breaks a number of
    devices out there that can not handle suspend properly, _AND_ the
    current patch is broken even for devices that do work properly under
    some situations.  Data loss is not a good thing to have happen, so
    this patch is reverted for now.  Oliver has more specifics about the
    issues involved here if anyone is curious.

The "disable autosuspend" patch has been in the -mm tree for a while,
and is being shipped by Ubuntu and Red Hat in their bleeding-edge
kernels in order to handle the huge number of broken devices.  openSUSE
will also get this patch for its next kernel release once the suse
developers return from wondering around the woods of the Czech Republic
next week.

Please pull from:
	master.kernel.org:/pub/scm/linux/kernel/git/gregkh/usb-2.6.git/

The full patches will be sent to the linux-usb-devel mailing list, if
anyone wants to see them.

thanks,

greg k-h


 drivers/usb/core/quirks.c      |    6 ++++++
 drivers/usb/storage/scsiglue.c |   13 ++++---------
 drivers/usb/storage/usb.c      |   27 +++++++--------------------
 3 files changed, 17 insertions(+), 29 deletions(-)

---------------

Alan Stern (1):
      USB: disable autosuspend by default for non-hubs

Greg Kroah-Hartman (1):
      Revert "usb-storage: implement autosuspend"



             reply	other threads:[~2007-09-13 13:30 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-13 13:33 Greg KH [this message]
2007-09-13 14:52 ` [GIT PATCH] USB autosuspend fixes for 2.6.23-rc6 Adrian Bunk
2007-09-13 15:20   ` Alan Stern
2007-09-13 15:40     ` Adrian Bunk
2007-09-13 16:07       ` Alan Stern
2007-09-13 16:34         ` Greg KH
2007-09-13 16:43         ` Linus Torvalds
2007-09-13 19:13           ` Alan Stern
2007-09-14  0:24             ` Matthew Dharm
2007-09-14 14:34               ` Alan Stern
2007-09-14  8:55             ` Jiri Kosina
2007-09-14  9:59               ` Greg KH
2007-09-13 19:26           ` Pete Zaitcev
2007-09-13 20:19         ` Adrian Bunk
2007-09-13 20:31           ` Alan Stern
2007-09-13 20:44           ` Linus Torvalds
2007-09-13 21:28             ` Adrian Bunk
2007-09-13 22:05               ` Adrian Bunk
2007-09-14  0:11                 ` Linus Torvalds
2007-09-14 13:21                   ` Mark Lord
2007-09-14 14:15                     ` Adrian Bunk
2007-09-14 14:29                 ` Alan Stern
2007-09-14 14:26               ` Alan Stern
  -- strict thread matches above, loose matches on Subject: below --
2007-09-17 12:56 Hans de Goede
2007-09-18 10:39 Joerg Schilling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070913133321.GA6362@kroah.com \
    --to=gregkh@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=oneukum@suse.de \
    --cc=stern@rowland.harvard.edu \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox