Re: [PATCH] Fix race with shared tag queue maps

Linus Torvalds
2007-09-13T15:43:34Z

On Thu, 13 Sep 2007, Jens Axboe wrote:
>
> My bad, I think I added the smp_mb__before_clear_bit() when it was
> __test_and_set_bit() like in the first hunk.

Ahh, that wouldn't work at all. The "__test_and_set_bit()" thing isn't
atomic at all, and no amount of memory barriers around it would help
(you'd need to use real locking, but at that point the memory barriers are
pointless anyway).

> + /*
> + * Ensure ordering between ->tag_index[tag] clear and tag clear
> + */
> + smp_mb__after_clear_bit();

You still left this one. But never mind - I already edited your original
patch and it's in my tree with both of those things removed.

Linus