From: aherrman@arcor.de
To: Luca Risolia <luca.risolia@studio.unibo.it>
Cc: akpm@linux-foundation.org, linux-usb-devel@lists.sourceforge.net,
video4linux-list@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] v4l: Build error with et61x251, if V4L1_COMPAT is not selected
Date: Fri, 14 Sep 2007 00:06:22 +0200 [thread overview]
Message-ID: <20070913220622.GA5764@devil> (raw)
In-Reply-To: <200709131707.16666.luca.risolia@studio.unibo.it>
On Thu, Sep 13, 2007 at 05:07:16PM +0200, Luca Risolia wrote:
> On Thursday 13 September 2007 14:36:27 aherrman@arcor.de wrote:
> > With current git tree I get an build error
> > for et61x251, if V4L1_COMPAT is not selected:
> >
> > drivers/media/video/et61x251/et61x251_core.c: In et61x251_show_:
> > drivers/media/video/et61x251/et61x251_core.c:718: error: implicit
> > declaration of to_video_device
> >
> > Fix: add VIDEO_V4L1_COMPAT as a dependency for this driver.
>
> No, wait. The driver really is V4L2 only. If you can, please fix it by
> replacing to_video_device() with container_of() instead:
>
> cam = video_get_drvdata(container_of(cd, struct video_device, class_dev));
Ah just some v4l1 remainders.
I'll do that.
Regards,
Andreas
next prev parent reply other threads:[~2007-09-13 22:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-13 12:36 [PATCH] v4l: Build error with et61x251, if V4L1_COMPAT is not selected aherrman
2007-09-13 15:07 ` Luca Risolia
2007-09-13 22:06 ` aherrman [this message]
2007-09-13 22:27 ` [PATCH] v4l: fix build error for et61x251 driver Andreas Herrmann
2007-09-13 22:28 ` Luca Risolia
2007-09-14 0:09 ` Linus Torvalds
2007-09-14 1:53 ` Luca Risolia
2007-09-14 7:48 ` aherrman
2007-09-14 12:50 ` Mauro Carvalho Chehab
2007-09-14 13:57 ` Luca Risolia
2007-09-14 15:56 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070913220622.GA5764@devil \
--to=aherrman@arcor.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=luca.risolia@studio.unibo.it \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox