From: Greg KH <greg@kroah.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Russell King <rmk@arm.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [PATCH] wake up from a serial port
Date: Thu, 13 Sep 2007 16:21:19 -0700 [thread overview]
Message-ID: <20070913232119.GA32307@kroah.com> (raw)
In-Reply-To: <20070912153610.11c4f5cb.akpm@linux-foundation.org>
On Wed, Sep 12, 2007 at 03:36:10PM -0700, Andrew Morton wrote:
> On Wed, 12 Sep 2007 20:50:10 +0200 (CEST)
> Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
>
> > Enable wakeup from serial ports, make it run-time configurable over sysfs,
> > e.g.,
> >
> > echo enabled > /sys/devices/platform/serial8250.0/tty/ttyS0/power/wakeup
> >
> > Requires
> >
> > # CONFIG_SYSFS_DEPRECATED is not set
> >
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> >
> > ---
> >
> > Following suggestions from Alan and Russell moved the may_wake_up checks
> > to serial_core.c. This time actually tested - it does even work. Could
> > someone, please, verify, that put_device after device_find_child is
> > correct?
>
> Seems right to me, from reading device_find_child() and its associated
> documentation.
Yes, that is correct.
thanks,
greg k-h
next prev parent reply other threads:[~2007-09-13 23:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200709100831.l8A8VUH6015446@imap1.linux-foundation.org>
[not found] ` <20070910132703.2dd92485@the-village.bc.nu>
[not found] ` <Pine.LNX.4.60.0709102251250.5200@poirot.grange>
[not found] ` <20070911081220.GA20847@flint.arm.linux.org.uk>
[not found] ` <Pine.LNX.4.60.0709111217470.19259@poirot.grange>
[not found] ` <20070911121057.34b9e066@the-village.bc.nu>
2007-09-12 18:50 ` [PATCH] wake up from a serial port Guennadi Liakhovetski
2007-09-12 21:06 ` Michael Mauch
2007-09-13 20:29 ` Guennadi Liakhovetski
2007-09-12 22:36 ` [PATCH] " Andrew Morton
2007-09-13 23:21 ` Greg KH [this message]
2007-09-14 8:34 ` Natsemi UART owner test request (was Re: [PATCH] wake up from a serial port) Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070913232119.GA32307@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=g.liakhovetski@gmx.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox