From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Nigel Cunningham <nigel@nigel.suspend2.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix failure to resume from initrds
Date: Fri, 14 Sep 2007 14:20:18 +0200 [thread overview]
Message-ID: <20070914122018.GA1671@elf.ucw.cz> (raw)
In-Reply-To: <200709141422.18788.rjw@sisk.pl>
Hi!
> From: Nigel Cunningham <nigel@nigel.suspend2.net>
>
> Commit 831441862956fffa17b9801db37e6ea1650b0f69 (Freezer: make kernel threads
> nonfreezable by default) breaks freezing when attempting to resume from an
> initrd, because the init (which is freezeable) spins while waiting for another
> thread to run /linuxrc, but doesn't check whether it has been told to enter
> the refrigerator. The original patch replaced a call to try_to_freeze() with a
> call to yield(). I believe a simple reversion is wrong because
> if !CONFIG_PM_SLEEP, try_to_freeze() is a noop. It should still yield.
>
> Signed-off-by: Nigel Cunningham <nigel@nigel.suspend2.net>
> Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
ACK.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-09-14 12:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-14 12:22 [PATCH] Fix failure to resume from initrds Rafael J. Wysocki
2007-09-14 12:20 ` Pavel Machek [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-09-11 3:54 Nigel Cunningham
2007-09-11 11:04 ` Rafael J. Wysocki
2007-09-11 11:27 ` Nigel Cunningham
2007-09-11 11:55 ` Rafael J. Wysocki
2007-09-11 13:01 ` Nigel Cunningham
2007-09-11 13:12 ` Rafael J. Wysocki
2007-09-11 13:23 ` Rafael J. Wysocki
2007-09-11 13:41 ` Nigel Cunningham
2007-09-11 19:25 ` Rafael J. Wysocki
2007-09-11 14:39 ` Linus Torvalds
2007-09-11 16:27 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070914122018.GA1671@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nigel@nigel.suspend2.net \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox