public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Denys Vlasenko <vda.linux@googlemail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] add consts where appropriate in sound/pci/hda/*
Date: Fri, 14 Sep 2007 18:48:05 +0100	[thread overview]
Message-ID: <200709141848.06027.vda.linux@googlemail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 793 bytes --]

Hi Takashi,

There is a lot of data structures in that code,
and most of them seems to be read-only.

I added const modifiers to most of such places:

   text    data     bss     dec     hex filename
 106315  179564      36  285915   45cdb snd-hda-intel.o
 283051    2624      36  285711   45c0f snd-hda-intel_patched.o

Patch is attached.

It moves "static struct hda_codec_preset *hda_preset_tables[]"
from hda_patch.h to hda_codec.c, and then adds
#include "hda_patch.h"
in a few .c files so that definitions of e.g.
const struct hda_codec_preset snd_hda_preset_analog[]
are checked to match declarations in hda_patch.h

The rest of the patch (bulk of it) adds "const"
in many places.

Patch is compile tested. Please apply.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
--
vda

[-- Attachment #2: constify_hda_codec.diff.bz2 --]
[-- Type: application/x-bzip2, Size: 18868 bytes --]

             reply	other threads:[~2007-09-14 17:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-14 17:48 Denys Vlasenko [this message]
2007-09-14 18:09 ` [PATCH] add consts where appropriate in sound/pci/hda/* Joe Perches
2007-09-14 19:34   ` Denys Vlasenko
2007-09-14 22:12 ` Denys Vlasenko
2007-09-15  9:43 ` Jan Engelhardt
2007-09-15 10:18   ` Sam Ravnborg
2007-09-15 10:29     ` Jan Engelhardt
2007-09-15 11:42       ` Denys Vlasenko
2007-09-15 12:40         ` Andreas Schwab
2007-09-15 13:47           ` Denys Vlasenko
2007-09-15 17:42             ` Jan Engelhardt
2007-09-17 10:01 ` Takashi Iwai
2007-09-17 21:53   ` Denys Vlasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200709141848.06027.vda.linux@googlemail.com \
    --to=vda.linux@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox