From: Sam Ravnborg <sam@ravnborg.org>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Denys Vlasenko <vda.linux@googlemail.com>,
Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add consts where appropriate in sound/pci/hda/*
Date: Sat, 15 Sep 2007 12:18:11 +0200 [thread overview]
Message-ID: <20070915101811.GA9934@uranus.ravnborg.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0709151143230.13411@fbirervta.pbzchgretzou.qr>
On Sat, Sep 15, 2007 at 11:43:40AM +0200, Jan Engelhardt wrote:
>
> On Sep 14 2007 18:48, Denys Vlasenko wrote:
> >Hi Takashi,
> >
> >There is a lot of data structures in that code,
> >and most of them seems to be read-only.
> >
> >I added const modifiers to most of such places:
> >
> > text data bss dec hex filename
> > 106315 179564 36 285915 45cdb snd-hda-intel.o
> > 283051 2624 36 285711 45c0f snd-hda-intel_patched.o
>
> This is kinda odd. Why did the _text_ size increase by constifying?
The data got converted from data to text because they were made const.
Making stuff const unfortunately does not make them disappear
albeit the embedded folks would have liked that.
Sam
next prev parent reply other threads:[~2007-09-15 10:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-14 17:48 [PATCH] add consts where appropriate in sound/pci/hda/* Denys Vlasenko
2007-09-14 18:09 ` Joe Perches
2007-09-14 19:34 ` Denys Vlasenko
2007-09-14 22:12 ` Denys Vlasenko
2007-09-15 9:43 ` Jan Engelhardt
2007-09-15 10:18 ` Sam Ravnborg [this message]
2007-09-15 10:29 ` Jan Engelhardt
2007-09-15 11:42 ` Denys Vlasenko
2007-09-15 12:40 ` Andreas Schwab
2007-09-15 13:47 ` Denys Vlasenko
2007-09-15 17:42 ` Jan Engelhardt
2007-09-17 10:01 ` Takashi Iwai
2007-09-17 21:53 ` Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070915101811.GA9934@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox