From: Jakub Jelinek <jakub@redhat.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: increase AT_VECTOR_SIZE to terminate saved_auxv properly
Date: Sat, 15 Sep 2007 10:01:06 -0400 [thread overview]
Message-ID: <20070915140106.GA7129@devserv.devel.redhat.com> (raw)
In-Reply-To: <20070914110057.GA10088@aepfle.de>
On Fri, Sep 14, 2007 at 01:00:57PM +0200, Olaf Hering wrote:
> include/asm-powerpc/elf.h has 6 entries in ARCH_DLINFO.
> fs/binfmt_elf.c has 14 unconditional NEW_AUX_ENT entries and 2
> conditional NEW_AUX_ENT entries.
> So in the worst case, saved_auxv does not get an AT_NULL entry at the
> end.
>
> Is an AT_NULL entry required or must userspace use the AT_VECTOR_SIZE
> to not loop past the end of the array?
Of course it is required, AT_VECTOR_SIZE is a kernel implementation detail.
> If AT_NULL is required, AT_VECTOR_SIZE should be changed from 44 to 46.
No, it should be computed instead from the number of target independent aux
vector pairs and then from an per-arch macro which says how many arch
specific aux vector pairs are needed.
Jakub
next prev parent reply other threads:[~2007-09-15 14:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-14 11:00 increase AT_VECTOR_SIZE to terminate saved_auxv properly Olaf Hering
2007-09-15 14:01 ` Jakub Jelinek [this message]
2007-09-17 8:54 ` Olaf Hering
2007-09-18 11:55 ` [PATCH] " Olaf Hering
2007-09-20 6:44 ` Andrew Morton
2007-09-20 19:19 ` Olaf Hering
2007-09-20 20:22 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070915140106.GA7129@devserv.devel.redhat.com \
--to=jakub@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).