From: Andi Kleen <andi@firstfloor.org>
To: Serge Belyshev <belyshev@depni.sinp.msu.ru>
Cc: Andi Kleen <ak@suse.de>,
patches@x86-64.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: x86_64: Remove unnecessary cast in prefetch()
Date: Sat, 15 Sep 2007 22:01:17 +0200 [thread overview]
Message-ID: <20070915200117.GC14501@one.firstfloor.org> (raw)
In-Reply-To: <878x78ig85.fsf@depni.sinp.msu.ru>
On Sat, Sep 15, 2007 at 10:40:26AM +0400, Serge Belyshev wrote:
> Andi Kleen <ak@suse.de> writes:
>
> >> This can be fixed better by using gcc's __builtin_prefetch().
> >
> > I changed it to just use that. Thanks.
> >
> > It seems like gcc 3.1/3.2 already supported it and that's the earliest gcc
> > still supported so it can be used unconditionally.
> >
>
> Hi!
>
> Will you submit this patch for inclusion into 2.6.23? It is important
Didn't plan it currently.
> to make kernel work with GCC 4.3 and above. (Also note that gcc 4.2 already
> smart enough to break that code, but kernel is just lucky currently).
How would it break the code exactly? It more sounded like an optimization
to me. Would it generate incorrect code without it?
-Andi
next prev parent reply other threads:[~2007-09-15 20:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-06 21:27 [PATCH]: x86_64: Remove unnecessary cast in prefetch() Serge Belyshev
2007-09-07 7:18 ` Andi Kleen
2007-09-15 6:40 ` Serge Belyshev
2007-09-15 20:01 ` Andi Kleen [this message]
2007-09-15 21:16 ` Serge Belyshev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070915200117.GC14501@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@suse.de \
--cc=belyshev@depni.sinp.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@x86-64.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox