SPARC{,64}: kernel_termios_to_user_termios_1 missing

SPARC{,64}: kernel_termios_to_user_termios_1 missing

[Horst H. von Brand]

git-describe says this is v2.6.23-rc6-168-g53a3f30
I'm getting:

  drivers/char/tty_ioctl.c: In function 'n_tty_ioctl':
  drivers/char/tty_ioctl.c:799: error: implicit declaration of function 'kernel_termios_to_user_termios_1'

This is a macro at the very end of include/asm-<foo>/termios.h for i686, on
SPARC and SPARC64 it is missing. Sorry, I've got no clue on how to define
this correctly here.

It is also missing on alpha, blackfin, parisc, sh64, sh, xtensa
-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                    Fono: +56 32 2654431
Universidad Tecnica Federico Santa Maria             +56 32 2654239
Casilla 110-V, Valparaiso, Chile               Fax:  +56 32 2797513

Re: SPARC{,64}: kernel_termios_to_user_termios_1 missing

[David Miller]

From: "Horst H. von Brand" <vonbrand@inf.utfsm.cl>
Date: Sat, 15 Sep 2007 17:37:55 -0400

> git-describe says this is v2.6.23-rc6-168-g53a3f30
> I'm getting:
> 
>   drivers/char/tty_ioctl.c: In function 'n_tty_ioctl':
>   drivers/char/tty_ioctl.c:799: error: implicit declaration of function 'kernel_termios_to_user_termios_1'
> 
> This is a macro at the very end of include/asm-<foo>/termios.h for i686, on
> SPARC and SPARC64 it is missing. Sorry, I've got no clue on how to define
> this correctly here.
> 
> It is also missing on alpha, blackfin, parisc, sh64, sh, xtensa

This has been reported and discussed extensively on the lists
over the past 4 or 5 days.

It is a well known issue, and if you just need to get the sparc64
build working so you can test it out just use the patch below:

diff --git a/include/asm-sparc/termios.h b/include/asm-sparc/termios.h
index d767f20..25e9cbb 100644
--- a/include/asm-sparc/termios.h
+++ b/include/asm-sparc/termios.h
@@ -142,6 +142,11 @@ struct winsize {
 	0; \
 })
 
+#define user_termios_to_kernel_termios_1(k, u) \
+	user_termios_to_kernel_termios(k, u)
+#define kernel_termios_to_user_termios_1(u, k) \
+	kernel_termios_to_user_termios(u, k)
+
 #endif	/* __KERNEL__ */
 
 #endif /* _SPARC_TERMIOS_H */
diff --git a/include/asm-sparc64/termios.h b/include/asm-sparc64/termios.h
index f05d390..6fc71e6 100644
--- a/include/asm-sparc64/termios.h
+++ b/include/asm-sparc64/termios.h
@@ -145,6 +145,11 @@ struct winsize {
 	err; \
 })
 
+#define user_termios_to_kernel_termios_1(k, u) \
+	user_termios_to_kernel_termios(k, u)
+#define kernel_termios_to_user_termios_1(u, k) \
+	kernel_termios_to_user_termios(u, k)
+
 #endif	/* __KERNEL__ */
 
 #endif /* _SPARC64_TERMIOS_H */

Re: SPARC{,64}: kernel_termios_to_user_termios_1 missing

[Andrew Morton]

On Sat, 15 Sep 2007 15:36:02 -0700 (PDT) David Miller <davem@davemloft.net> wrote:

> From: "Horst H. von Brand" <vonbrand@inf.utfsm.cl>
> Date: Sat, 15 Sep 2007 17:37:55 -0400
> 
> > git-describe says this is v2.6.23-rc6-168-g53a3f30
> > I'm getting:
> > 
> >   drivers/char/tty_ioctl.c: In function 'n_tty_ioctl':
> >   drivers/char/tty_ioctl.c:799: error: implicit declaration of function 'kernel_termios_to_user_termios_1'
> > 
> > This is a macro at the very end of include/asm-<foo>/termios.h for i686, on
> > SPARC and SPARC64 it is missing. Sorry, I've got no clue on how to define
> > this correctly here.
> > 
> > It is also missing on alpha, blackfin, parisc, sh64, sh, xtensa
> 
> This has been reported and discussed extensively on the lists
> over the past 4 or 5 days.

Hopefully bb8bd3a52a5dbca8bea31bfc72dacfb384170e69 (merged six hours ago)
will have fixed this.  It Works For Me.

Re: SPARC{,64}: kernel_termios_to_user_termios_1 missing

[David Miller]

From: Andrew Morton <akpm@linux-foundation.org>
Date: Sun, 16 Sep 2007 00:42:31 -0700

> Hopefully bb8bd3a52a5dbca8bea31bfc72dacfb384170e69 (merged six hours ago)
> will have fixed this.  It Works For Me.

Yep, looks good here too.

Re: SPARC{,64}: kernel_termios_to_user_termios_1 missing

[Adrian McMenamin]

On 16/09/2007, Andrew Morton <akpm@linux-foundation.org> wrote:

>
> Hopefully bb8bd3a52a5dbca8bea31bfc72dacfb384170e69 (merged six hours ago)
> will have fixed this.  It Works For Me.

It also works on SH4