Re: VM/VFS bug with large amount of memory and file systems?

Andrew Morton
2007-09-19T22:47:08Z

On Wed, 19 Sep 2007 18:12:38 -0400
Rik van Riel <riel@redhat.com> wrote:

> Andrew Morton wrote:
> > On Mon, 17 Sep 2007 16:46:47 -0400
> > Rik van Riel <riel@redhat.com> wrote:
>
> >> Is the slab defragmentation code in -mm or upstream already
> >> or can I find it on the mailing list?
> >
> > Is on lkml and linux-mm: http://lkml.org/lkml/2007/8/31/329
>
> > I think the whole approach is reasonable. It's mainly a matter of going
> > through it all with a toothcomb
>
> I've spent the last two days combing through the patches.

Thanks. So would it be appropriate for Christoph to add the
thus-far-undefined reviewed-by tag to the next version?

> Except for the one doubt I had (resolved in email), and
> one function name comment (on patch 18/26)

yeah. Basic rule: if the reviewer had to ask a question then others will
later ask themselves the same question when reading the code. So this is a
very good indicator that there is a missing code comment.

> the code looks
> good to me.

Cool.