From: "Michael Kerrisk" <mtk-manpages@gmx.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: corbet@lwn.net, jengelh@computergmbh.de, hch@lst.de,
stable@kernel.org, drepper@redhat.com,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de, rdunlap@xenotime.net,
vda.linux@googlemail.com, davidel@xmailserver.org
Subject: Re: [PATCH] remove timerd() syscall number
Date: Mon, 17 Sep 2007 23:02:16 +0200 [thread overview]
Message-ID: <20070917210216.284780@gmx.net> (raw)
In-Reply-To: <20070917134315.968c1902.akpm@linux-foundation.org>
> > I hope I've done this right... This patch, against 2.6.23-rc6,
> > removes the timerfd() syscall (which in any case had a bug
> > on its 2.6.22 release) from all architectures, so that we
> > can have some breathing space to think about the API design.
> > All of the existing timerfd() code is left intact.
>
> I think a minimally-intrusive implementation would be
>
> --- a/fs/timerfd.c~a
> +++ a/fs/timerfd.c
> @@ -159,6 +159,8 @@ asmlinkage long sys_timerfd(int ufd, int
> struct inode *inode;
> struct itimerspec ktmr;
>
> + return -ENOSYS;
> +
> if (copy_from_user(&ktmr, utmr, sizeof(ktmr)))
> return -EFAULT;
>
> _
>
> or, better,
>
> --- a/init/Kconfig~a
> +++ a/init/Kconfig
> @@ -491,6 +491,7 @@ config SIGNALFD
>
> config TIMERFD
> bool "Enable timerfd() system call" if EMBEDDED
> + depends on BROKEN
> select ANON_INODES
> default y
> help
> _
Cough! Right then. I take it you'll apply one of those then?
--
Michael Kerrisk
maintainer of Linux man pages Sections 2, 3, 4, 5, and 7
Want to help with man page maintenance?
Grab the latest tarball at
http://www.kernel.org/pub/linux/docs/manpages ,
read the HOWTOHELP file and grep the source
files for 'FIXME'.
prev parent reply other threads:[~2007-09-17 21:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 16:58 [PATCH] remove timerd() syscall number Michael Kerrisk
2007-09-17 20:43 ` Andrew Morton
2007-09-17 21:02 ` Michael Kerrisk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070917210216.284780@gmx.net \
--to=mtk-manpages@gmx.net \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=davidel@xmailserver.org \
--cc=drepper@redhat.com \
--cc=hch@lst.de \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox