From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760126AbXIQWZ5 (ORCPT ); Mon, 17 Sep 2007 18:25:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759086AbXIQWZr (ORCPT ); Mon, 17 Sep 2007 18:25:47 -0400 Received: from mx1.suse.de ([195.135.220.2]:42323 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758161AbXIQWZq (ORCPT ); Mon, 17 Sep 2007 18:25:46 -0400 From: Andi Kleen Organization: SUSE Linux Products GmbH, Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg) To: Christoph Lameter Subject: Re: [PATCH] 2.6.23-rc6: Fix NUMA Memory Policy Reference Counting Date: Tue, 18 Sep 2007 00:25:40 +0200 User-Agent: KMail/1.9.6 Cc: Lee Schermerhorn , linux-kernel , akpm@linux-foundation.org, eric.whitney@hp.com, Mel Gorman References: <20070830185053.22619.96398.sendpatchset@localhost> <1190057534.5460.131.camel@localhost> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200709180025.40837.ak@suse.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > The patch does require concurrent increments and decrements in the main > fault patch. The potential is to create another bouncing cacheline for > concurrent faults. This looks like it would cause a performance issue. While may be true correctness is always more important than performance. So I think this is the right thing for .23. Any performance improvements if needed can come later. -Andi