From: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: containers@lists.osdl.org, Ingo Molnar <mingo@elte.hu>,
ckrm-tech@lists.sourceforge.net, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Hookup group-scheduler with task container infrastructure
Date: Tue, 18 Sep 2007 16:14:37 +0530 [thread overview]
Message-ID: <20070918104437.GA18221@linux.vnet.ibm.com> (raw)
In-Reply-To: <20070918171945.d0593a08.kamezawa.hiroyu@jp.fujitsu.com>
On Tue, Sep 18, 2007 at 05:19:45PM +0900, KAMEZAWA Hiroyuki wrote:
> Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com> wrote:
> > + tg->cfs_rq = kzalloc(sizeof(cfs_rq) * num_possible_cpus(), GFP_KERNEL);
> > + if (!tg->cfs_rq)
> > + goto err;
> > + tg->se = kzalloc(sizeof(se) * num_possible_cpus(), GFP_KERNEL);
> > + if (!tg->se)
> > + goto err;
> Sorry for very lazy responce..
>
> num_possible_cpus() just returns # of possible cpus. Then it will not return
> Max-cpu-id to be used. I think just use NR_CPUS here is an easy way.
Good catch! Yes, you are right, the pointer array needs to be NR_CPUS
size.
On closer examination, I think I can simply use alloc_percpu() here.
Will send a patch after some testing.
--
Regards,
vatsa
prev parent reply other threads:[~2007-09-18 10:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-10 17:10 [PATCH] Hookup group-scheduler with task container infrastructure Srivatsa Vaddagiri
2007-09-10 17:05 ` Jan Engelhardt
2007-09-10 17:23 ` Srivatsa Vaddagiri
2007-09-10 17:22 ` Andrew Morton
2007-09-10 17:41 ` Jan Engelhardt
2007-09-10 17:46 ` Srivatsa Vaddagiri
2007-09-10 22:28 ` Dmitry Adamushko
2007-09-11 4:41 ` Srivatsa Vaddagiri
2007-09-11 9:53 ` Dmitry Adamushko
2007-09-12 11:42 ` Srivatsa Vaddagiri
2007-09-12 12:10 ` Srivatsa Vaddagiri
2007-09-12 16:25 ` Dmitry Adamushko
2007-09-13 12:33 ` Srivatsa Vaddagiri
2007-09-14 9:41 ` Ingo Molnar
2007-09-14 15:59 ` Srivatsa Vaddagiri
2007-09-14 16:22 ` Srivatsa Vaddagiri
2007-09-10 22:37 ` Dmitry Adamushko
2007-09-10 22:45 ` Paul Menage
2007-09-11 7:20 ` Cedric Le Goater
2007-09-11 15:22 ` Randy Dunlap
2007-09-11 15:37 ` Jan Engelhardt
2007-09-11 15:51 ` Srivatsa Vaddagiri
2007-09-11 15:53 ` Randy Dunlap
2007-09-11 15:44 ` Paul Menage
2007-09-10 17:28 ` Srivatsa Vaddagiri
2007-09-10 17:42 ` Jan Engelhardt
2007-09-10 18:38 ` [Devel] " Paul Menage
2007-09-11 4:44 ` Srivatsa Vaddagiri
2007-09-18 8:19 ` KAMEZAWA Hiroyuki
2007-09-18 10:44 ` Srivatsa Vaddagiri [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070918104437.GA18221@linux.vnet.ibm.com \
--to=vatsa@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=ckrm-tech@lists.sourceforge.net \
--cc=containers@lists.osdl.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox