From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Andi Kleen <andi@firstfloor.org>,
prasanna@in.ibm.com, anil.s.keshavamurthy@intel.com,
davem@davemloft.net
Subject: Re: [patch 08/11] Text Edit Lock - kprobes i386
Date: Tue, 18 Sep 2007 22:11:54 +0530 [thread overview]
Message-ID: <20070918164154.GA14594@in.ibm.com> (raw)
In-Reply-To: <20070917184210.454982104@polymtl.ca>
On Mon, Sep 17, 2007 at 02:40:39PM -0400, Mathieu Desnoyers wrote:
> Make kprobes use text_set instead of text_poke.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Tested-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> CC: Andi Kleen <andi@firstfloor.org>
> CC: prasanna@in.ibm.com
> CC: ananth@in.ibm.com
> CC: anil.s.keshavamurthy@intel.com
> CC: davem@davemloft.net
> ---
> arch/i386/kernel/kprobes.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> Index: linux-2.6-lttng/arch/i386/kernel/kprobes.c
> ===================================================================
> --- linux-2.6-lttng.orig/arch/i386/kernel/kprobes.c 2007-09-11 15:47:50.000000000 -0400
> +++ linux-2.6-lttng/arch/i386/kernel/kprobes.c 2007-09-11 15:48:52.000000000 -0400
> @@ -177,12 +177,13 @@ int __kprobes arch_prepare_kprobe(struct
>
> void __kprobes arch_arm_kprobe(struct kprobe *p)
> {
> - text_poke(p->addr, ((unsigned char []){BREAKPOINT_INSTRUCTION}), 1);
> + text_poke(p->addr, INIT_ARRAY(unsigned char, BREAKPOINT_INSTRUCTION, 1),
> + 1);
> }
>
> void __kprobes arch_disarm_kprobe(struct kprobe *p)
> {
> - text_poke(p->addr, &p->opcode, 1);
> + text_poke(p->addr, INIT_ARRAY(unsigned char, p->opcode, 1), 1);
> }
>
> void __kprobes arch_remove_kprobe(struct kprobe *p)
>
> --
> Mathieu Desnoyers
> Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
> OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2007-09-18 16:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 18:40 [patch 00/11] Text Edit Lock Mathieu Desnoyers
2007-09-17 18:40 ` [patch 01/11] Kprobes - use a mutex to protect the instruction pages list Mathieu Desnoyers
2007-09-17 18:40 ` [patch 02/11] Kprobes - do not use kprobes mutex in arch code Mathieu Desnoyers
2007-09-17 18:40 ` [patch 03/11] Kprobes - declare kprobe_mutex static Mathieu Desnoyers
2007-09-17 18:40 ` [patch 04/11] Add INIT_ARRAY() to kernel.h Mathieu Desnoyers
2007-09-17 18:40 ` [patch 05/11] Text Edit Lock - Architecture Independent Code Mathieu Desnoyers
2007-09-17 18:40 ` [patch 06/11] Text Edit Lock - Alternative code for i386 and x86_64 Mathieu Desnoyers
2007-09-17 18:40 ` [patch 07/11] Text Edit Lock - kprobes architecture independent support Mathieu Desnoyers
2007-09-18 16:40 ` Ananth N Mavinakayanahalli
2007-09-17 18:40 ` [patch 08/11] Text Edit Lock - kprobes i386 Mathieu Desnoyers
2007-09-18 16:41 ` Ananth N Mavinakayanahalli [this message]
2007-09-17 18:40 ` [patch 09/11] Text Edit Lock - kprobes x86_64 Mathieu Desnoyers
2007-09-18 16:42 ` Ananth N Mavinakayanahalli
2007-09-17 18:40 ` [patch 10/11] Text Edit Lock - i386 standardize debug rodata Mathieu Desnoyers
2007-09-17 18:40 ` [patch 11/11] Text Edit Lock - x86_64 " Mathieu Desnoyers
-- strict thread matches above, loose matches on Subject: below --
2007-09-18 21:06 [patch 00/11] Text Edit Lock for 2.6.23-rc6-mm1 Mathieu Desnoyers
2007-09-18 21:06 ` [patch 08/11] Text Edit Lock - kprobes i386 Mathieu Desnoyers
2007-08-20 20:19 [patch 00/11] Text Edit Lock / text poke Mathieu Desnoyers
2007-08-20 20:19 ` [patch 08/11] Text Edit Lock - kprobes i386 Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070918164154.GA14594@in.ibm.com \
--to=ananth@in.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=prasanna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox