UML dead with current -git?

UML dead with current -git?

[Philipp Marek]

[-- Attachment #1: Type: text/plain, Size: 1662 bytes --]

Hello everybody,

I'm trying to build a UML machine on x86-64 (config attached) 
but I'm getting compile errors.


What am I doing wrong?

	make allnoconfig ARCH=um
	make menuconfig ARCH=um
selected a few options
	make -j 5 ARCH=um
	..
	include/linux/jiffies.h:225:31: error: division by zero in #if
	include/linux/jiffies.h:225:46: warning: "SHIFT_HZ" is not defined
	In file included from arch/um/include/sysdep/kernel-offsets.h:2,
                 from arch/um/kernel/asm-offsets.c:1:
	include/linux/sched.h: In function 'dequeue_signal_lock':
	include/linux/sched.h:1506: error: implicit declaration of function 'local_irq_save'
	include/linux/sched.h:1508: error: implicit declaration of function 'local_irq_restore'
	In file included from include/linux/crypto.h:21,
                 from arch/um/include/sysdep/kernel-offsets.h:5,
                 from arch/um/kernel/asm-offsets.c:1:
	include/linux/module.h: At top level:
	include/linux/module.h:222: error: requested alignment is not a constant
	In file included from arch/um/kernel/asm-offsets.c:1:
	arch/um/include/sysdep/kernel-offsets.h:25:29: error: asm/arch/unistd.h: No such file or directory
	In file included from arch/um/include/sysdep/kernel-offsets.h:30,
                 from arch/um/kernel/asm-offsets.c:1:
	arch/um/include/common-offsets.h: In function 'foo':
	arch/um/include/common-offsets.h:8: error: 'struct thread_struct' has no member named 'regs'
	make[1]: *** [arch/um/kernel/asm-offsets.s] Error 1
	make: *** [prepare0] Error 2


Thank you for all help.


Regards,

Phil


-- 
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

[-- Attachment #2: make output --]
[-- Type: text/plain, Size: 6457 bytes --]

  SYMLINK arch/um/include/kern_constants.h
make[1]: `arch/um/sys-x86_64/user-offsets.s' is up to date.
  CHK     arch/um/include/user_constants.h
  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  CC      arch/um/kernel/asm-offsets.s
In file included from include/asm/pda.h:8,
                 from include/asm/current.h:7,
                 from include/linux/capability.h:47,
                 from include/linux/sched.h:49,
                 from arch/um/include/sysdep/kernel-offsets.h:2,
                 from arch/um/kernel/asm-offsets.c:1:
include/asm/page.h:89:6: warning: "CONFIG_PHYSICAL_START" is not defined
In file included from include/linux/prefetch.h:14,
                 from include/linux/list.h:8,
                 from include/linux/preempt.h:11,
                 from include/linux/spinlock.h:49,
                 from include/linux/seqlock.h:29,
                 from include/linux/time.h:8,
                 from include/linux/timex.h:57,
                 from include/linux/sched.h:53,
                 from arch/um/include/sysdep/kernel-offsets.h:2,
                 from arch/um/kernel/asm-offsets.c:1:
include/asm/processor.h:78: error: 'CONFIG_X86_L1_CACHE_SHIFT' undeclared here (not in a function)
include/asm/processor.h:78: error: requested alignment is not a constant
include/asm/processor.h:198: error: requested alignment is not a constant
In file included from include/linux/sched.h:54,
                 from arch/um/include/sysdep/kernel-offsets.h:2,
                 from arch/um/kernel/asm-offsets.c:1:
include/linux/jiffies.h:18:5: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:20:7: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:22:7: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:24:7: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:26:7: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:28:7: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:30:7: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:33:3: error: #error You lose.
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: error: division by zero in #if
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: error: division by zero in #if
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: error: division by zero in #if
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: error: division by zero in #if
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: error: division by zero in #if
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: error: division by zero in #if
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: error: division by zero in #if
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: error: division by zero in #if
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: error: division by zero in #if
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: error: division by zero in #if
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: error: division by zero in #if
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: error: division by zero in #if
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: error: division by zero in #if
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: error: division by zero in #if
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: error: division by zero in #if
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: warning: "CONFIG_HZ" is not defined
include/linux/jiffies.h:225:31: error: division by zero in #if
include/linux/jiffies.h:225:46: warning: "SHIFT_HZ" is not defined
In file included from arch/um/include/sysdep/kernel-offsets.h:2,
                 from arch/um/kernel/asm-offsets.c:1:
include/linux/sched.h: In function 'dequeue_signal_lock':
include/linux/sched.h:1506: error: implicit declaration of function 'local_irq_save'
include/linux/sched.h:1508: error: implicit declaration of function 'local_irq_restore'
In file included from include/linux/crypto.h:21,
                 from arch/um/include/sysdep/kernel-offsets.h:5,
                 from arch/um/kernel/asm-offsets.c:1:
include/linux/module.h: At top level:
include/linux/module.h:222: error: requested alignment is not a constant
In file included from arch/um/kernel/asm-offsets.c:1:
arch/um/include/sysdep/kernel-offsets.h:25:29: error: asm/arch/unistd.h: No such file or directory
In file included from arch/um/include/sysdep/kernel-offsets.h:30,
                 from arch/um/kernel/asm-offsets.c:1:
arch/um/include/common-offsets.h: In function 'foo':
arch/um/include/common-offsets.h:8: error: 'struct thread_struct' has no member named 'regs'
make[1]: *** [arch/um/kernel/asm-offsets.s] Error 1
make: *** [prepare0] Error 2

[-- Attachment #3: .config --]
[-- Type: text/plain, Size: 6769 bytes --]

#
# Automatically generated make config: don't edit
# Linux kernel version: 2.6.23-rc6
# Tue Sep 18 17:11:16 2007
#
CONFIG_DEFCONFIG_LIST="arch/$ARCH/defconfig"
CONFIG_GENERIC_HARDIRQS=y
CONFIG_UML=y
CONFIG_MMU=y
CONFIG_NO_IOMEM=y
# CONFIG_TRACE_IRQFLAGS_SUPPORT is not set
CONFIG_LOCKDEP_SUPPORT=y
# CONFIG_STACKTRACE_SUPPORT is not set
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_GENERIC_BUG=y
CONFIG_IRQ_RELEASE_METHOD=y

#
# UML-specific options
#
CONFIG_STATIC_LINK=y
CONFIG_MODE_SKAS=y
CONFIG_UML_X86=y
CONFIG_64BIT=y
CONFIG_RWSEM_GENERIC_SPINLOCK=y
CONFIG_SEMAPHORE_SLEEPERS=y
CONFIG_TOP_ADDR=0x80000000
CONFIG_3_LEVEL_PGTABLES=y
CONFIG_STUB_CODE=0x7fbfffe000
CONFIG_STUB_DATA=0x7fbffff000
CONFIG_STUB_START=0x7fbfffe000
# CONFIG_ARCH_HAS_SC_SIGNALS is not set
# CONFIG_ARCH_REUSE_HOST_VSYSCALL_AREA is not set
CONFIG_SMP_BROKEN=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_SELECT_MEMORY_MODEL=y
CONFIG_FLATMEM_MANUAL=y
# CONFIG_DISCONTIGMEM_MANUAL is not set
# CONFIG_SPARSEMEM_MANUAL is not set
CONFIG_FLATMEM=y
CONFIG_FLAT_NODE_MEM_MAP=y
# CONFIG_SPARSEMEM_STATIC is not set
CONFIG_SPLIT_PTLOCK_CPUS=4
CONFIG_RESOURCES_64BIT=y
CONFIG_ZONE_DMA_FLAG=0
CONFIG_VIRT_TO_BUS=y
CONFIG_LD_SCRIPT_STATIC=y
# CONFIG_NET is not set
CONFIG_BINFMT_ELF=y
# CONFIG_BINFMT_MISC is not set
CONFIG_HOSTFS=y
# CONFIG_HPPFS is not set
CONFIG_MCONSOLE=y
# CONFIG_MAGIC_SYSRQ is not set
CONFIG_NEST_LEVEL=0
CONFIG_KERNEL_STACK_ORDER=1
# CONFIG_UML_REAL_TIME_CLOCK is not set

#
# General setup
#
CONFIG_EXPERIMENTAL=y
CONFIG_BROKEN_ON_SMP=y
CONFIG_INIT_ENV_ARG_LIMIT=128
CONFIG_LOCALVERSION=""
# CONFIG_LOCALVERSION_AUTO is not set
# CONFIG_SWAP is not set
# CONFIG_SYSVIPC is not set
# CONFIG_BSD_PROCESS_ACCT is not set
# CONFIG_USER_NS is not set
# CONFIG_IKCONFIG is not set
CONFIG_LOG_BUF_SHIFT=14
# CONFIG_SYSFS_DEPRECATED is not set
# CONFIG_RELAY is not set
# CONFIG_BLK_DEV_INITRD is not set
CONFIG_CC_OPTIMIZE_FOR_SIZE=y
CONFIG_SYSCTL=y
# CONFIG_EMBEDDED is not set
CONFIG_UID16=y
CONFIG_SYSCTL_SYSCALL=y
CONFIG_KALLSYMS=y
CONFIG_KALLSYMS_ALL=y
CONFIG_KALLSYMS_EXTRA_PASS=y
CONFIG_HOTPLUG=y
CONFIG_PRINTK=y
CONFIG_BUG=y
CONFIG_ELF_CORE=y
CONFIG_BASE_FULL=y
CONFIG_FUTEX=y
CONFIG_ANON_INODES=y
CONFIG_EPOLL=y
CONFIG_SIGNALFD=y
CONFIG_TIMERFD=y
CONFIG_EVENTFD=y
CONFIG_SHMEM=y
CONFIG_VM_EVENT_COUNTERS=y
CONFIG_SLUB_DEBUG=y
# CONFIG_SLAB is not set
CONFIG_SLUB=y
# CONFIG_SLOB is not set
CONFIG_RT_MUTEXES=y
# CONFIG_TINY_SHMEM is not set
CONFIG_BASE_SMALL=0
CONFIG_MODULES=y
CONFIG_MODULE_UNLOAD=y
# CONFIG_MODULE_FORCE_UNLOAD is not set
CONFIG_MODVERSIONS=y
# CONFIG_MODULE_SRCVERSION_ALL is not set
CONFIG_KMOD=y
CONFIG_BLOCK=y
# CONFIG_BLK_DEV_IO_TRACE is not set
# CONFIG_BLK_DEV_BSG is not set

#
# IO Schedulers
#
CONFIG_IOSCHED_NOOP=y
# CONFIG_IOSCHED_AS is not set
# CONFIG_IOSCHED_DEADLINE is not set
# CONFIG_IOSCHED_CFQ is not set
# CONFIG_DEFAULT_AS is not set
# CONFIG_DEFAULT_DEADLINE is not set
# CONFIG_DEFAULT_CFQ is not set
CONFIG_DEFAULT_NOOP=y
CONFIG_DEFAULT_IOSCHED="noop"
# CONFIG_BLK_DEV is not set
# CONFIG_MMAPPER is not set

#
# Character Devices
#
# CONFIG_STDERR_CONSOLE is not set
CONFIG_STDIO_CONSOLE=y
# CONFIG_SSL is not set
# CONFIG_NULL_CHAN is not set
# CONFIG_PORT_CHAN is not set
# CONFIG_PTY_CHAN is not set
# CONFIG_TTY_CHAN is not set
# CONFIG_XTERM_CHAN is not set
CONFIG_NOCONFIG_CHAN=y
CONFIG_CON_ZERO_CHAN="fd:0,fd:1"
CONFIG_CON_CHAN="xterm"
CONFIG_SSL_CHAN="pty"
# CONFIG_UNIX98_PTYS is not set
# CONFIG_LEGACY_PTYS is not set
# CONFIG_RAW_DRIVER is not set
# CONFIG_WATCHDOG is not set
# CONFIG_UML_SOUND is not set
# CONFIG_SOUND is not set
# CONFIG_HOSTAUDIO is not set
# CONFIG_HW_RANDOM is not set
# CONFIG_UML_RANDOM is not set

#
# Generic Driver Options
#
CONFIG_STANDALONE=y
# CONFIG_PREVENT_FIRMWARE_BUILD is not set
# CONFIG_FW_LOADER is not set
# CONFIG_DEBUG_DRIVER is not set
# CONFIG_DEBUG_DEVRES is not set
# CONFIG_SYS_HYPERVISOR is not set

#
# Networking
#

#
# File systems
#
# CONFIG_EXT2_FS is not set
# CONFIG_EXT3_FS is not set
# CONFIG_EXT4DEV_FS is not set
# CONFIG_REISERFS_FS is not set
# CONFIG_JFS_FS is not set
# CONFIG_FS_POSIX_ACL is not set
# CONFIG_XFS_FS is not set
# CONFIG_GFS2_FS is not set
# CONFIG_MINIX_FS is not set
# CONFIG_ROMFS_FS is not set
# CONFIG_INOTIFY is not set
# CONFIG_QUOTA is not set
CONFIG_DNOTIFY=y
# CONFIG_AUTOFS_FS is not set
# CONFIG_AUTOFS4_FS is not set
# CONFIG_FUSE_FS is not set

#
# CD-ROM/DVD Filesystems
#
# CONFIG_ISO9660_FS is not set
# CONFIG_UDF_FS is not set

#
# DOS/FAT/NT Filesystems
#
# CONFIG_MSDOS_FS is not set
# CONFIG_VFAT_FS is not set
# CONFIG_NTFS_FS is not set

#
# Pseudo filesystems
#
CONFIG_PROC_FS=y
# CONFIG_PROC_KCORE is not set
CONFIG_PROC_SYSCTL=y
CONFIG_SYSFS=y
# CONFIG_TMPFS is not set
# CONFIG_HUGETLB_PAGE is not set
CONFIG_RAMFS=y
# CONFIG_CONFIGFS_FS is not set

#
# Miscellaneous filesystems
#
# CONFIG_ADFS_FS is not set
# CONFIG_AFFS_FS is not set
# CONFIG_HFS_FS is not set
# CONFIG_HFSPLUS_FS is not set
# CONFIG_BEFS_FS is not set
# CONFIG_BFS_FS is not set
# CONFIG_EFS_FS is not set
# CONFIG_CRAMFS is not set
# CONFIG_VXFS_FS is not set
# CONFIG_HPFS_FS is not set
# CONFIG_QNX4FS_FS is not set
# CONFIG_SYSV_FS is not set
# CONFIG_UFS_FS is not set

#
# Partition Types
#
# CONFIG_PARTITION_ADVANCED is not set
CONFIG_MSDOS_PARTITION=y

#
# Native Language Support
#
# CONFIG_NLS is not set

#
# Security options
#
# CONFIG_KEYS is not set
# CONFIG_SECURITY is not set
# CONFIG_CRYPTO is not set

#
# Library routines
#
# CONFIG_CRC_CCITT is not set
# CONFIG_CRC16 is not set
# CONFIG_CRC_ITU_T is not set
# CONFIG_CRC32 is not set
# CONFIG_CRC7 is not set
# CONFIG_LIBCRC32C is not set
CONFIG_PLIST=y
CONFIG_HAS_DMA=y

#
# SCSI device support
#
# CONFIG_RAID_ATTRS is not set
# CONFIG_SCSI is not set
# CONFIG_SCSI_DMA is not set
# CONFIG_SCSI_NETLINK is not set
# CONFIG_MD is not set
# CONFIG_INPUT is not set

#
# Kernel hacking
#
# CONFIG_PRINTK_TIME is not set
# CONFIG_ENABLE_MUST_CHECK is not set
CONFIG_UNUSED_SYMBOLS=y
CONFIG_DEBUG_FS=y
CONFIG_DEBUG_KERNEL=y
# CONFIG_DEBUG_SHIRQ is not set
CONFIG_DETECT_SOFTLOCKUP=y
CONFIG_SCHED_DEBUG=y
# CONFIG_SCHEDSTATS is not set
# CONFIG_TIMER_STATS is not set
# CONFIG_SLUB_DEBUG_ON is not set
# CONFIG_DEBUG_RT_MUTEXES is not set
# CONFIG_RT_MUTEX_TESTER is not set
# CONFIG_DEBUG_SPINLOCK is not set
# CONFIG_DEBUG_MUTEXES is not set
# CONFIG_DEBUG_SPINLOCK_SLEEP is not set
# CONFIG_DEBUG_LOCKING_API_SELFTESTS is not set
# CONFIG_DEBUG_KOBJECT is not set
CONFIG_DEBUG_BUGVERBOSE=y
CONFIG_DEBUG_INFO=y
# CONFIG_DEBUG_VM is not set
# CONFIG_DEBUG_LIST is not set
CONFIG_FRAME_POINTER=y
CONFIG_FORCED_INLINING=y
# CONFIG_RCU_TORTURE_TEST is not set
# CONFIG_FAULT_INJECTION is not set
# CONFIG_GPROF is not set
# CONFIG_GCOV is not set
# CONFIG_DEBUG_STACK_USAGE is not set

Re: UML dead with current -git?

[Jeff Dike]

On Tue, Sep 18, 2007 at 05:14:33PM +0200, Philipp Marek wrote:
> I'm trying to build a UML machine on x86-64 (config attached) 
> but I'm getting compile errors.

Builds for me.  Did you start with an mrproper?  These errors look
like the UML build getting confused by left-overs from an x86_64
build.

				Jeff

-- 
Work email - jdike at linux dot intel dot com

Re: UML dead with current -git?

[Sam Ravnborg]

On Tue, Sep 18, 2007 at 01:13:13PM -0400, Jeff Dike wrote:
> On Tue, Sep 18, 2007 at 05:14:33PM +0200, Philipp Marek wrote:
> > I'm trying to build a UML machine on x86-64 (config attached) 
> > but I'm getting compile errors.
> 
> Builds for me.  Did you start with an mrproper?  These errors look
> like the UML build getting confused by left-overs from an x86_64
> build.
Sounds to me like a known issue by you. Can you give a few more details
so we maybe can get it fixed?

	Sam

Re: UML dead with current -git?

[Philipp Marek]

On Tuesday 18 September 2007 Jeff Dike wrote:
> On Tue, Sep 18, 2007 at 05:14:33PM +0200, Philipp Marek wrote:
> > I'm trying to build a UML machine on x86-64 (config attached)
> > but I'm getting compile errors.
>
> Builds for me.  Did you start with an mrproper?  These errors look
> like the UML build getting confused by left-overs from an x86_64
> build.
No, I didn't. Shouldn't that get cleaned up by a (completely new) config 
anyway?

I'll try and tell you tomorrow.


Thank you!


Regards,

Phil


-- 
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

Re: UML dead with current -git?

[Jeff Dike]

On Tue, Sep 18, 2007 at 07:55:13PM +0200, Sam Ravnborg wrote:
> Sounds to me like a known issue by you. Can you give a few more details
> so we maybe can get it fixed?

I believe what happened here is an x86_64 build followed by a
UML/x86_64 build with no intervening mrproper.

I've always considered this to be a "don't do that" sort of thing.
However, maybe we could stick the arch of the current build somewhere
in the tree, check that before any serious part of a subsequent
build, and error out if $ARCH is different.

				Jeff

-- 
Work email - jdike at linux dot intel dot com

Re: UML dead with current -git?

[Philipp Marek]

On Wednesday 19 September 2007 Jeff Dike wrote:
> On Tue, Sep 18, 2007 at 07:55:13PM +0200, Sam Ravnborg wrote:
> > Sounds to me like a known issue by you. Can you give a few more details
> > so we maybe can get it fixed?
> I believe what happened here is an x86_64 build followed by a
> UML/x86_64 build with no intervening mrproper.
Yes, after a "make mrproper" it compiles fine.
However, the .config is gone afterwards ...

> I've always considered this to be a "don't do that" sort of thing.
> However, maybe we could stick the arch of the current build somewhere
> in the tree, check that before any serious part of a subsequent
> build, and error out if $ARCH is different.
Well, on this line it may be nice to be able to put the target architecture 
somewhere ...
	make mrproper
	make menuconfig ARCH=um
	make ARCH=um
... some tweaking
	make menuconfig
and the .config is overwritten with the "wrong" architecture.
(I know about .config.bak and so on ... just a small wish)


Thank you!


Regards,

Phil

-- 
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

Re: UML dead with current -git?

[Randy Dunlap]

On Wed, 19 Sep 2007 14:43:23 +0200 Philipp Marek wrote:

> On Wednesday 19 September 2007 Jeff Dike wrote:
> > On Tue, Sep 18, 2007 at 07:55:13PM +0200, Sam Ravnborg wrote:
> > > Sounds to me like a known issue by you. Can you give a few more details
> > > so we maybe can get it fixed?
> > I believe what happened here is an x86_64 build followed by a
> > UML/x86_64 build with no intervening mrproper.
> Yes, after a "make mrproper" it compiles fine.
> However, the .config is gone afterwards ...
> 
> > I've always considered this to be a "don't do that" sort of thing.
> > However, maybe we could stick the arch of the current build somewhere
> > in the tree, check that before any serious part of a subsequent
> > build, and error out if $ARCH is different.
> Well, on this line it may be nice to be able to put the target architecture 
> somewhere ...
> 	make mrproper
> 	make menuconfig ARCH=um
> 	make ARCH=um
> ... some tweaking
> 	make menuconfig
> and the .config is overwritten with the "wrong" architecture.
> (I know about .config.bak and so on ... just a small wish)

Yes, I've tried to coerce the top-level Makefile into honoring/using
the include/asm symlink if it exists, i.e., taking ARCH from
readlink include/asm && sed -e 's/include-asm//', but sadly my
makefile foo was not good enough.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: UML dead with current -git?

[Philipp Marek]

Hello Randy!

On Wednesday 19 September 2007 Randy Dunlap wrote:
> Yes, I've tried to coerce the top-level Makefile into honoring/using
> the include/asm symlink if it exists, i.e., taking ARCH from
> readlink include/asm && sed -e 's/include-asm//', but sadly my
> makefile foo was not good enough.
How about that?
	readlink include/asm
returns
	asm-um
in my case, so I only have to strip the "asm-" part ...


Regards,

Phil


diff --git a/Makefile b/Makefile
index e0fdf49..c9284ba 100644
--- a/Makefile
+++ b/Makefile
@@ -163,6 +163,9 @@ SUBARCH := $(shell uname -m | sed -e s/i.86/i386/ -e s/sun4u/sparc64/ \
                                  -e s/s390x/s390/ -e s/parisc64/parisc/ \
                                  -e s/ppc.*/powerpc/ -e s/mips.*/mips/ )

+# sadly perl is defined below ... so we can't use it here, can we?
+ASMARCH        := $(shell test -s include/asm && readlink include/asm | cut -f2 -d-)
+
 # Cross compiling and selecting different set of gcc/bin-utils
 # ---------------------------------------------------------------------------
 #
@@ -182,7 +185,7 @@ SUBARCH := $(shell uname -m | sed -e s/i.86/i386/ -e s/sun4u/sparc64/ \
 # Default value for CROSS_COMPILE is not to prefix executables
 # Note: Some architectures assign CROSS_COMPILE in their arch/*/Makefile

-ARCH           ?= $(SUBARCH)
+ARCH           ?= $(or $(SUBARCH), $(ASMARCH))
 CROSS_COMPILE  ?=

 # Architecture as present in compile.h


-- 
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

Re: UML dead with current -git?

[Randy Dunlap]

On Wed, 19 Sep 2007 18:17:51 +0200 Philipp Marek wrote:

> Hello Randy!
> 
> On Wednesday 19 September 2007 Randy Dunlap wrote:
> > Yes, I've tried to coerce the top-level Makefile into honoring/using
> > the include/asm symlink if it exists, i.e., taking ARCH from
> > readlink include/asm && sed -e 's/include-asm//', but sadly my
> > makefile foo was not good enough.
> How about that?
> 	readlink include/asm
> returns
> 	asm-um
> in my case, so I only have to strip the "asm-" part ...
> 
> 
> Regards,
> 
> Phil
> 
> 
> diff --git a/Makefile b/Makefile
> index e0fdf49..c9284ba 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -163,6 +163,9 @@ SUBARCH := $(shell uname -m | sed -e s/i.86/i386/ -e s/sun4u/sparc64/ \
>                                   -e s/s390x/s390/ -e s/parisc64/parisc/ \
>                                   -e s/ppc.*/powerpc/ -e s/mips.*/mips/ )
> 
> +# sadly perl is defined below ... so we can't use it here, can we?
> +ASMARCH        := $(shell test -s include/asm && readlink include/asm | cut -f2 -d-)
> +
>  # Cross compiling and selecting different set of gcc/bin-utils
>  # ---------------------------------------------------------------------------
>  #
> @@ -182,7 +185,7 @@ SUBARCH := $(shell uname -m | sed -e s/i.86/i386/ -e s/sun4u/sparc64/ \
>  # Default value for CROSS_COMPILE is not to prefix executables
>  # Note: Some architectures assign CROSS_COMPILE in their arch/*/Makefile
> 
> -ARCH           ?= $(SUBARCH)
> +ARCH           ?= $(or $(SUBARCH), $(ASMARCH))
>  CROSS_COMPILE  ?=
> 
>  # Architecture as present in compile.h
> 
> 
> -- 

This doesn't work when there is no include/asm symlink.

It also didn't apply cleanly due to tab(s) being converted
to spaces (but of course I fixed that part).

---
~Randy

Re: UML dead with current -git?

[Jeff Dike]

On Wed, Sep 19, 2007 at 06:17:51PM +0200, Philipp Marek wrote:
> How about that?
> 	readlink include/asm
> returns
> 	asm-um
> in my case, so I only have to strip the "asm-" part ...

It doesn't handle O= directories...

				Jeff

-- 
Work email - jdike at linux dot intel dot com

Re: UML dead with current -git?

[Ph. Marek]

Hello Randy!

> This doesn't work when there is no include/asm symlink.
Why? I specifically test for that, and tried it on my machine.
What's the bug?
ASMARCH should come out empty, and the ?= and $(or) should take care of
the rest ...

> It also didn't apply cleanly due to tab(s) being converted
> to spaces (but of course I fixed that part).
Yes, sorry. I'll try to attach inline next time.


Regards,

Phil

-- 
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

Re: UML dead with current -git?

[Ph. Marek]

Hello Jeff,

> On Wed, Sep 19, 2007 at 06:17:51PM +0200, Philipp Marek wrote:
>> How about that?
>> 	readlink include/asm
>> returns
>> 	asm-um
>> in my case, so I only have to strip the "asm-" part ...
>
> It doesn't handle O= directories...
Sorry, I don't understand you. What are "0=" directories? Do you mean that
if there's no include/ directory?


Well, I guess that there are non-obvious corner cases in the include/asm
symlink usage, that amateurs simply do not know ...


Regards,

Phil


-- 
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

Re: UML dead with current -git?

[Sam Ravnborg]

On Thu, Sep 20, 2007 at 07:44:49AM +0200, Ph. Marek wrote:
> Hello Jeff,
> 
> > On Wed, Sep 19, 2007 at 06:17:51PM +0200, Philipp Marek wrote:
> >> How about that?
> >> 	readlink include/asm
> >> returns
> >> 	asm-um
> >> in my case, so I only have to strip the "asm-" part ...
> >
> > It doesn't handle O= directories...
> Sorry, I don't understand you. What are "0=" directories?

When building a kernel you can specify an other output directory
so you do not mix up your source tree with generated files.
To do so do like this:

Prepare the stuff:
mkdir ~/kernel
cp .config ~/kernel
make mrproper

And then build the kernel:
make O=~/kernel


	Sam

Re: UML dead with current -git?

[Philipp Marek]

>> > It doesn't handle O= directories...
>> Sorry, I don't understand you. What are "0=" directories?
>
> When building a kernel you can specify an other output directory
> so you do not mix up your source tree with generated files.
> To do so do like this:
>
> Prepare the stuff:
> mkdir ~/kernel
> cp .config ~/kernel
> make mrproper
>
> And then build the kernel:
> make O=~/kernel
Oh yes ...  thats the character 'o', not the number zero ...
Sorry, changing the font shows that :-)


Yes, that's right. Wouldn't $(srctree) help? That's defined just above, so
should be fine.


Regards,

Phil


-- 
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

Re: UML dead with current -git?

[Sam Ravnborg]

On Thu, Sep 20, 2007 at 09:25:38AM +0200, Philipp Marek wrote:
> 
> >> > It doesn't handle O= directories...
> >> Sorry, I don't understand you. What are "0=" directories?
> >
> > When building a kernel you can specify an other output directory
> > so you do not mix up your source tree with generated files.
> > To do so do like this:
> >
> > Prepare the stuff:
> > mkdir ~/kernel
> > cp .config ~/kernel
> > make mrproper
> >
> > And then build the kernel:
> > make O=~/kernel
> Oh yes ...  thats the character 'o', not the number zero ...
> Sorry, changing the font shows that :-)
> 
> 
> Yes, that's right. Wouldn't $(srctree) help? That's defined just above, so
> should be fine.
We want a solution that:
- Always use the same ARCH as before
- Error out if user specify another ARCH
- Tell what ARCH is used to user

I will inspired by yprs and other patches try to cook up something.
Hopefully my make-foo suffice.

	Sam

Re: UML dead with current -git?

[Randy Dunlap]

On Thu, 20 Sep 2007 07:42:38 +0200 (CEST) Ph. Marek wrote:

> Hello Randy!
> 
> > This doesn't work when there is no include/asm symlink.
> Why? I specifically test for that, and tried it on my machine.
> What's the bug?
> ASMARCH should come out empty, and the ?= and $(or) should take care of
> the rest ...

Sorry, I can't reproduce it now.
The variable was coming out empty though.  I saw path strings like
  linux-2.6.23-rc6/arch//Makefile

Hopefully Sam can fix it all up.  :)

> > It also didn't apply cleanly due to tab(s) being converted
> > to spaces (but of course I fixed that part).
> Yes, sorry. I'll try to attach inline next time.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***