public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	Andi Kleen <ak@muc.de>, Chuck Ebbert <cebbert@redhat.com>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [patch 4/7] Immediate Values - i386 Optimization
Date: Wed, 19 Sep 2007 14:31:13 -0400	[thread overview]
Message-ID: <20070919183113.GC7428@Krystal> (raw)
In-Reply-To: <46F15ED4.40002@zytor.com>

* H. Peter Anvin (hpa@zytor.com) wrote:
> Jeremy Fitzhardinge wrote:
> > 
> > Cross-cache-line, sure.  But what about just not sizeof aligned?  If its
> > enough to avoid cross-cache-line, then that's simpler.
> > 
> 
> Not really.  It pretty much comes down to the same problem.
> 
> > Which is something I was going to comment on: Mathieu, you try to align
> > the constant itself, but you don't prevent the instruction overall from
> > crossing a cache line.  Given how delicate all this stuff is, it seems
> > like a good idea to do that.
> 
> Given how delicate all his stuff is, it would be interesting to know the
> magnitude of the expected payoff, which I personally don't remember seeing.
> 

Please have a look at the patch header at:
http://lkml.org/lkml/2007/9/18/346

And at the documentation:
http://lkml.org/lkml/2007/9/18/375

Where I provide speedups experienced with this patch. Please note that
my primary goal is to provide non intrusive instrumentation with the
Linux Kernel Markers, and the immediate values are the underlying
mechanism that help enabling/disabling dynamically instrumentation sites
with the smallest effect possible (and still get the local variables
in the middle of a function compiled with -O2...).

Mathieu

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68

  reply	other threads:[~2007-09-19 18:36 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-18 21:07 [patch 0/7] Immediate Values for 2.6.23-rc6-mm1 Mathieu Desnoyers
2007-09-18 21:07 ` [patch 1/7] Immediate Values - Architecture Independent Code Mathieu Desnoyers
2007-09-18 21:07 ` [patch 2/7] Immediate Values - Kconfig menu in EMBEDDED Mathieu Desnoyers
2007-09-18 22:02   ` Randy Dunlap
2007-09-19 11:13     ` Mathieu Desnoyers
2007-09-18 21:07 ` [patch 3/7] Immediate Values - Move Kprobes i386 restore_interrupt to kdebug.h Mathieu Desnoyers
2007-09-18 21:07 ` [patch 4/7] Immediate Values - i386 Optimization Mathieu Desnoyers
2007-09-18 21:51   ` Jeremy Fitzhardinge
2007-09-18 22:12     ` H. Peter Anvin
2007-09-18 22:27       ` Jeremy Fitzhardinge
2007-09-19 13:01         ` Mathieu Desnoyers
2007-09-19 16:03           ` Mathieu Desnoyers
2007-09-19 16:12           ` H. Peter Anvin
2007-09-19 17:30             ` Jeremy Fitzhardinge
2007-09-19 17:39               ` H. Peter Anvin
2007-09-19 18:31                 ` Mathieu Desnoyers [this message]
2007-09-19 18:22               ` Mathieu Desnoyers
2007-10-20 16:47         ` Mathieu Desnoyers
2007-10-20 18:32           ` H. Peter Anvin
2007-10-22 15:40             ` Mathieu Desnoyers
2007-10-22 16:39               ` H. Peter Anvin
2007-10-22  9:53           ` Andi Kleen
2007-09-19 11:00       ` Mathieu Desnoyers
2007-09-18 22:14     ` Andi Kleen
2007-09-18 22:29       ` Jeremy Fitzhardinge
2007-09-18 22:33         ` H. Peter Anvin
2007-09-18 22:44         ` Andi Kleen
2007-09-19 11:08       ` Mathieu Desnoyers
2007-09-19 11:14         ` Andi Kleen
2007-09-19 10:59     ` Mathieu Desnoyers
2007-09-20 10:24   ` Denys Vlasenko
2007-09-21 13:31     ` Mathieu Desnoyers
2007-09-18 21:07 ` [patch 5/7] Immediate Values - Powerpc Optimization Mathieu Desnoyers
2007-09-18 21:07 ` [patch 6/7] Immediate Values - Documentation Mathieu Desnoyers
2007-09-18 21:07 ` [patch 7/7] Scheduler Profiling - Use Immediate Values Mathieu Desnoyers
  -- strict thread matches above, loose matches on Subject: below --
2007-09-17 18:42 [patch 0/7] " Mathieu Desnoyers
2007-09-17 18:42 ` [patch 4/7] Immediate Values - i386 Optimization Mathieu Desnoyers
2007-09-18  6:04   ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070919183113.GC7428@Krystal \
    --to=mathieu.desnoyers@polymtl.ca \
    --cc=ak@muc.de \
    --cc=akpm@linux-foundation.org \
    --cc=cebbert@redhat.com \
    --cc=hch@infradead.org \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox