From: Andrew Morton <akpm@linux-foundation.org>
To: Olaf Hering <olaf@aepfle.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] increase AT_VECTOR_SIZE to terminate saved_auxv properly
Date: Wed, 19 Sep 2007 23:44:11 -0700 [thread overview]
Message-ID: <20070919234411.d5bf33ea.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070918115504.GA609@aepfle.de>
On Tue, 18 Sep 2007 13:55:04 +0200 Olaf Hering <olaf@aepfle.de> wrote:
> include/asm-powerpc/elf.h has 6 entries in ARCH_DLINFO.
> fs/binfmt_elf.c has 14 unconditional NEW_AUX_ENT entries and 2
> conditional NEW_AUX_ENT entries.
> So in the worst case, saved_auxv does not get an AT_NULL entry at the
> end.
>
> The saved_auxv array must be terminated with an AT_NULL entry.
> Make the size of mm_struct->saved_auxv arch dependend,
> based on the number of ARCH_DLINFO entries.
I'm not very confident that this will work well with the
already-queued move-mm_struct-and-vm_area_struct.patch.
It moves the saved_auxv[AT_VECTOR_SIZE] definition over into
mm_types.h and mm_types.h doesn't include sched.h.
next prev parent reply other threads:[~2007-09-20 6:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-14 11:00 increase AT_VECTOR_SIZE to terminate saved_auxv properly Olaf Hering
2007-09-15 14:01 ` Jakub Jelinek
2007-09-17 8:54 ` Olaf Hering
2007-09-18 11:55 ` [PATCH] " Olaf Hering
2007-09-20 6:44 ` Andrew Morton [this message]
2007-09-20 19:19 ` Olaf Hering
2007-09-20 20:22 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070919234411.d5bf33ea.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).