public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: Dmitry Adamushko <dmitry.adamushko@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: fix to use invalid sched_class
Date: Thu, 20 Sep 2007 09:17:30 +0200	[thread overview]
Message-ID: <20070920071730.GB29903@elte.hu> (raw)
In-Reply-To: <46F1B872.1050307@ct.jp.nec.com>


* Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:

> Dmitry Adamushko wrote:
> >>> Hi Ingo,
> >>>
> >>> I found an issue about the scheduler.
> >>> If you need a test case, please let me know.
> >>> Here is a patch.
> >>> [ ... ]
> >>> The new thread should be valid scheduler class before queuing.
> >>> This patch fixes to set the suitable scheduler class.
> >> Nice fix! It's a 2.6.23 must-have fix - i'll push it out into the 
> >> scheduler tree. Thanks!
> > 
> > I think, the following approach would be a bit more appropriate
> > (the missing addition to the already existing "don't leak PI boosting prio"):
> > 
> > (not tested)
> > 
> Thank you for reviewing my patch.
> Yes, your approach looks better than mine.
> I've tested it and it looks working fine in my test case.
> I attached the test case.
> 
> Will you write a patch to replace mine?

thanks for testing it - we can queue Dmitry's clean-up for v2.6.24 
(please send me a patch for v2.6.23-rc7). The most important step was to 
get your fix into v2.6.23.

	Ingo


  reply	other threads:[~2007-09-20  7:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-19 22:05 [PATCH] sched: fix to use invalid sched_class Dmitry Adamushko
2007-09-20  0:01 ` Hiroshi Shimamoto
2007-09-20  7:17   ` Ingo Molnar [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-09-19 21:14 Hiroshi Shimamoto
2007-09-19 21:37 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070920071730.GB29903@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=dmitry.adamushko@gmail.com \
    --cc=h-shimamoto@ct.jp.nec.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox