public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* 2.6.23-rc6-mm1 powerpc - kgdb is broken
@ 2007-09-19 12:23 Kamalesh Babulal
  2007-09-19 18:53 ` Jason Wessel
  0 siblings, 1 reply; 9+ messages in thread
From: Kamalesh Babulal @ 2007-09-19 12:23 UTC (permalink / raw)
  To: akpm, linux-kernel, amitkale, trini

Hi Andrew,

The kgdb seems to be broken on the powerpc, while compiling with
allyesconfig.

  LD [M]  drivers/isdn/hysdn/hysdn.o
  CC [M]  drivers/net/kgdboe.o
  CC [M]  drivers/scsi/scsi_wait_scan.o
In file included from include/linux/kgdb.h:22,
                 from drivers/net/kgdboe.c:28:
include/asm/kgdb.h:34: error: 'debugger' redeclared as different kind of symbol
include/asm/system.h:85: error: previous definition of 'debugger' was here
include/asm/kgdb.h:35: error: 'debugger_bpt' redeclared as different kind of symbol
include/asm/system.h:87: error: previous definition of 'debugger_bpt' was here
include/asm/kgdb.h:36: error: 'debugger_sstep' redeclared as different kind of symbol
include/asm/system.h:88: error: previous definition of 'debugger_sstep' was here
include/asm/kgdb.h:37: error: 'debugger_iabr_match' redeclared as different kind of symbol
include/asm/system.h:89: error: previous definition of 'debugger_iabr_match' was here
include/asm/kgdb.h:38: error: 'debugger_dabr_match' redeclared as different kind of symbol
include/asm/system.h:90: error: previous definition of 'debugger_dabr_match' was here
include/asm/kgdb.h:39: error: 'debugger_fault_handler' redeclared as different kind of symbol
include/asm/system.h:91: error: previous definition of 'debugger_fault_handler' was here
In file included from drivers/net/kgdboe.c:28:
include/linux/kgdb.h:69: error: 'BREAK_INSTR_SIZE' undeclared here (not in a function)
make[3]: *** [drivers/net/kgdboe.o] Error 1
make[2]: *** [drivers/net] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [drivers] Error 2
make: *** [modules] Error 2

-- 

Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: 2.6.23-rc6-mm1 powerpc - kgdb is broken
  2007-09-19 12:23 2.6.23-rc6-mm1 powerpc - kgdb is broken Kamalesh Babulal
@ 2007-09-19 18:53 ` Jason Wessel
  2007-09-19 19:36   ` Andrew Morton
  0 siblings, 1 reply; 9+ messages in thread
From: Jason Wessel @ 2007-09-19 18:53 UTC (permalink / raw)
  To: Kamalesh Babulal; +Cc: akpm, linux-kernel, amitkale, trini

I am not exactly sure how to fix this...

Another git tree is overriding the patch to include/asm-powerpc/kgdb.h
in the -mm tree.   The patches as I provide them against 2.6.23-rc6 for
KGDB work correctly for ppc/powerpc in 32 and 64 bit modes and compile
correctly.

At issue is that someone merged a bogus copy of asm-ppc/kgdb.h from the
git tree in -mm that is called: git-powerpc.patch.

Jason.

Kamalesh Babulal wrote:
> Hi Andrew,
>
> The kgdb seems to be broken on the powerpc, while compiling with
> allyesconfig.
>
>   LD [M]  drivers/isdn/hysdn/hysdn.o
>   CC [M]  drivers/net/kgdboe.o
>   CC [M]  drivers/scsi/scsi_wait_scan.o
> In file included from include/linux/kgdb.h:22,
>                  from drivers/net/kgdboe.c:28:
> include/asm/kgdb.h:34: error: 'debugger' redeclared as different kind of symbol
> include/asm/system.h:85: error: previous definition of 'debugger' was here
> include/asm/kgdb.h:35: error: 'debugger_bpt' redeclared as different kind of symbol
> include/asm/system.h:87: error: previous definition of 'debugger_bpt' was here
> include/asm/kgdb.h:36: error: 'debugger_sstep' redeclared as different kind of symbol
> include/asm/system.h:88: error: previous definition of 'debugger_sstep' was here
> include/asm/kgdb.h:37: error: 'debugger_iabr_match' redeclared as different kind of symbol
> include/asm/system.h:89: error: previous definition of 'debugger_iabr_match' was here
> include/asm/kgdb.h:38: error: 'debugger_dabr_match' redeclared as different kind of symbol
> include/asm/system.h:90: error: previous definition of 'debugger_dabr_match' was here
> include/asm/kgdb.h:39: error: 'debugger_fault_handler' redeclared as different kind of symbol
> include/asm/system.h:91: error: previous definition of 'debugger_fault_handler' was here
> In file included from drivers/net/kgdboe.c:28:
> include/linux/kgdb.h:69: error: 'BREAK_INSTR_SIZE' undeclared here (not in a function)
> make[3]: *** [drivers/net/kgdboe.o] Error 1
> make[2]: *** [drivers/net] Error 2
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [drivers] Error 2
> make: *** [modules] Error 2
>
>   


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: 2.6.23-rc6-mm1 powerpc - kgdb is broken
  2007-09-19 18:53 ` Jason Wessel
@ 2007-09-19 19:36   ` Andrew Morton
  2007-09-20  5:23     ` Paul Mackerras
  0 siblings, 1 reply; 9+ messages in thread
From: Andrew Morton @ 2007-09-19 19:36 UTC (permalink / raw)
  To: Jason Wessel; +Cc: Kamalesh Babulal, linux-kernel, amitkale, trini

On Wed, 19 Sep 2007 13:53:01 -0500 Jason Wessel <jason.wessel@windriver.com> wrote:

> I am not exactly sure how to fix this...
> 
> Another git tree is overriding the patch to include/asm-powerpc/kgdb.h
> in the -mm tree.   The patches as I provide them against 2.6.23-rc6 for
> KGDB work correctly for ppc/powerpc in 32 and 64 bit modes and compile
> correctly.
> 
> At issue is that someone merged a bogus copy of asm-ppc/kgdb.h from the
> git tree in -mm that is called: git-powerpc.patch.

Yeah, this was pointed out and largely ignored.

I'm afraid you'll have to wait until that powerpc stuff hits mainline
and then fix it all up.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: 2.6.23-rc6-mm1 powerpc - kgdb is broken
  2007-09-19 19:36   ` Andrew Morton
@ 2007-09-20  5:23     ` Paul Mackerras
  2007-09-20  5:53       ` Andrew Morton
  2007-09-20  7:38       ` Christoph Hellwig
  0 siblings, 2 replies; 9+ messages in thread
From: Paul Mackerras @ 2007-09-20  5:23 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Jason Wessel, Kamalesh Babulal, linux-kernel, amitkale, trini

Andrew Morton writes:

> On Wed, 19 Sep 2007 13:53:01 -0500 Jason Wessel <jason.wessel@windriver.com> wrote:
> 
> > I am not exactly sure how to fix this...
> > 
> > Another git tree is overriding the patch to include/asm-powerpc/kgdb.h
> > in the -mm tree.   The patches as I provide them against 2.6.23-rc6 for
> > KGDB work correctly for ppc/powerpc in 32 and 64 bit modes and compile
> > correctly.
> > 
> > At issue is that someone merged a bogus copy of asm-ppc/kgdb.h from the
> > git tree in -mm that is called: git-powerpc.patch.
> 
> Yeah, this was pointed out and largely ignored.
> 
> I'm afraid you'll have to wait until that powerpc stuff hits mainline
> and then fix it all up.

I could remove all the kgdb support from arch/powerpc as a first step,
if that would make it easier to pull in the new stuff...

Paul.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: 2.6.23-rc6-mm1 powerpc - kgdb is broken
  2007-09-20  5:23     ` Paul Mackerras
@ 2007-09-20  5:53       ` Andrew Morton
  2007-09-20  7:38       ` Christoph Hellwig
  1 sibling, 0 replies; 9+ messages in thread
From: Andrew Morton @ 2007-09-20  5:53 UTC (permalink / raw)
  To: Paul Mackerras
  Cc: Jason Wessel, Kamalesh Babulal, linux-kernel, amitkale, trini

On Thu, 20 Sep 2007 15:23:19 +1000 Paul Mackerras <paulus@samba.org> wrote:

> Andrew Morton writes:
> 
> > On Wed, 19 Sep 2007 13:53:01 -0500 Jason Wessel <jason.wessel@windriver.com> wrote:
> > 
> > > I am not exactly sure how to fix this...
> > > 
> > > Another git tree is overriding the patch to include/asm-powerpc/kgdb.h
> > > in the -mm tree.   The patches as I provide them against 2.6.23-rc6 for
> > > KGDB work correctly for ppc/powerpc in 32 and 64 bit modes and compile
> > > correctly.
> > > 
> > > At issue is that someone merged a bogus copy of asm-ppc/kgdb.h from the
> > > git tree in -mm that is called: git-powerpc.patch.
> > 
> > Yeah, this was pointed out and largely ignored.
> > 
> > I'm afraid you'll have to wait until that powerpc stuff hits mainline
> > and then fix it all up.
> 
> I could remove all the kgdb support from arch/powerpc as a first step,
> if that would make it easier to pull in the new stuff...
> 

I don't know if/when the new stuff will be merged - it's missed 2.6.24.

It might be better to proceed as you intended.  Presumably it won't be too
hard to hack things back into shape.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: 2.6.23-rc6-mm1 powerpc - kgdb is broken
  2007-09-20  5:23     ` Paul Mackerras
  2007-09-20  5:53       ` Andrew Morton
@ 2007-09-20  7:38       ` Christoph Hellwig
  2007-09-28 10:37         ` Kamalesh Babulal
  1 sibling, 1 reply; 9+ messages in thread
From: Christoph Hellwig @ 2007-09-20  7:38 UTC (permalink / raw)
  To: Paul Mackerras
  Cc: Andrew Morton, Jason Wessel, Kamalesh Babulal, linux-kernel,
	amitkale, trini

On Thu, Sep 20, 2007 at 03:23:19PM +1000, Paul Mackerras wrote:
> I could remove all the kgdb support from arch/powerpc as a first step,
> if that would make it easier to pull in the new stuff...

Given that the existing powerpc kgdb bits didn't seem to work at all when
I tried them that seems like a perfectly fine thing to do.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: 2.6.23-rc6-mm1 powerpc - kgdb is broken
  2007-09-20  7:38       ` Christoph Hellwig
@ 2007-09-28 10:37         ` Kamalesh Babulal
  2007-09-28 10:47           ` Thomas Gleixner
  0 siblings, 1 reply; 9+ messages in thread
From: Kamalesh Babulal @ 2007-09-28 10:37 UTC (permalink / raw)
  To: Paul Mackerras, linux-kernel, amitkale, trini
  Cc: Andrew Morton, Christoph Hellwig, Jason Wessel, Andy Whitcroft

Christoph Hellwig wrote:
> On Thu, Sep 20, 2007 at 03:23:19PM +1000, Paul Mackerras wrote:
>   
>> I could remove all the kgdb support from arch/powerpc as a first step,
>> if that would make it easier to pull in the new stuff...
>>     
>
> Given that the existing powerpc kgdb bits didn't seem to work at all when
> I tried them that seems like a perfectly fine thing to do.
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>   
Hi Paul,

The kgdb is also broken with 2.6.23-rc8-mm2 on the powerpc .
The below patch disables the kgdb from getting compiled over
powerpc platform.

Signed-off-by : Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
---

--- linux-2.6.23-rc8/lib/Kconfig.kgdb   2007-09-28 06:33:37.000000000 +0530
+++ linux-2.6.23-rc8/lib/~Kconfig.kgdb  2007-09-28 23:48:33.000000000 +0530
@@ -14,7 +14,7 @@ config KGDB
        bool "KGDB: kernel debugging with remote gdb"
        select WANT_EXTRA_DEBUG_INFORMATION
        select KGDB_ARCH_HAS_SHADOW_INFO if X86_64
-       depends on DEBUG_KERNEL && (ARM || X86 || MIPS || (SUPERH && !SUPERH64) || IA64 || PPC)
+       depends on DEBUG_KERNEL && (ARM || X86 || MIPS || (SUPERH && !SUPERH64) || IA64 || !PPC)
        help
          If you say Y here, it will be possible to remotely debug the
          kernel using gdb.  Documentation of kernel debugger is available

-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: 2.6.23-rc6-mm1 powerpc - kgdb is broken
  2007-09-28 10:37         ` Kamalesh Babulal
@ 2007-09-28 10:47           ` Thomas Gleixner
  2007-09-28 12:28             ` 2.6.23-rc6-mm1 powerpc - kgdb is broken [Resending PATCH] Kamalesh Babulal
  0 siblings, 1 reply; 9+ messages in thread
From: Thomas Gleixner @ 2007-09-28 10:47 UTC (permalink / raw)
  To: Kamalesh Babulal
  Cc: Paul Mackerras, linux-kernel, amitkale, trini, Andrew Morton,
	Christoph Hellwig, Jason Wessel, Andy Whitcroft

On Fri, 2007-09-28 at 16:07 +0530, Kamalesh Babulal wrote:
> The kgdb is also broken with 2.6.23-rc8-mm2 on the powerpc .
> The below patch disables the kgdb from getting compiled over
> powerpc platform.
> 
> Signed-off-by : Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> ---
> 
> --- linux-2.6.23-rc8/lib/Kconfig.kgdb   2007-09-28 06:33:37.000000000 +0530
> +++ linux-2.6.23-rc8/lib/~Kconfig.kgdb  2007-09-28 23:48:33.000000000 +0530
> @@ -14,7 +14,7 @@ config KGDB
>         bool "KGDB: kernel debugging with remote gdb"
>         select WANT_EXTRA_DEBUG_INFORMATION
>         select KGDB_ARCH_HAS_SHADOW_INFO if X86_64
> -       depends on DEBUG_KERNEL && (ARM || X86 || MIPS || (SUPERH && !SUPERH64) || IA64 || PPC)
> +       depends on DEBUG_KERNEL && (ARM || X86 || MIPS || (SUPERH && !SUPERH64) || IA64 || !PPC)

This enables the KGDB config for _ALL_ platforms except powerpc. 

Just remove PPC completely.

	tglx



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: 2.6.23-rc6-mm1 powerpc - kgdb is broken [Resending PATCH]
  2007-09-28 10:47           ` Thomas Gleixner
@ 2007-09-28 12:28             ` Kamalesh Babulal
  0 siblings, 0 replies; 9+ messages in thread
From: Kamalesh Babulal @ 2007-09-28 12:28 UTC (permalink / raw)
  To: Paul Mackerras
  Cc: Thomas Gleixner, linux-kernel, amitkale, trini, Andrew Morton,
	Christoph Hellwig, Jason Wessel, Andy Whitcroft

Thomas Gleixner wrote:
> On Fri, 2007-09-28 at 16:07 +0530, Kamalesh Babulal wrote:
>   
>> The kgdb is also broken with 2.6.23-rc8-mm2 on the powerpc .
>> The below patch disables the kgdb from getting compiled over
>> powerpc platform.
>>
>> Signed-off-by : Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
>> ---
>>
>> --- linux-2.6.23-rc8/lib/Kconfig.kgdb   2007-09-28 06:33:37.000000000 +0530
>> +++ linux-2.6.23-rc8/lib/~Kconfig.kgdb  2007-09-28 23:48:33.000000000 +0530
>> @@ -14,7 +14,7 @@ config KGDB
>>         bool "KGDB: kernel debugging with remote gdb"
>>         select WANT_EXTRA_DEBUG_INFORMATION
>>         select KGDB_ARCH_HAS_SHADOW_INFO if X86_64
>> -       depends on DEBUG_KERNEL && (ARM || X86 || MIPS || (SUPERH && !SUPERH64) || IA64 || PPC)
>> +       depends on DEBUG_KERNEL && (ARM || X86 || MIPS || (SUPERH && !SUPERH64) || IA64 || !PPC)
>>     
>
> This enables the KGDB config for _ALL_ platforms except powerpc. 
>
> Just remove PPC completely.
>
> 	tglx
>   
Thanks thomas for the suggestion, resending the patch.

Signed-off-by : Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
---

--- linux-2.6.23-rc8/lib/Kconfig.kgdb   2007-09-28 17:46:55.000000000 +0530
+++ linux-2.6.23-rc8/lib/~Kconfig.kgdb  2007-09-28 17:51:43.000000000 +0530
@@ -14,7 +14,7 @@ config KGDB
        bool "KGDB: kernel debugging with remote gdb"
        select WANT_EXTRA_DEBUG_INFORMATION
        select KGDB_ARCH_HAS_SHADOW_INFO if X86_64
-       depends on DEBUG_KERNEL && (ARM || X86 || MIPS || (SUPERH && !SUPERH64) || IA64 || PPC)
+       depends on DEBUG_KERNEL && (ARM || X86 || MIPS || (SUPERH && !SUPERH64) || IA64)
        help
          If you say Y here, it will be possible to remotely debug the
          kernel using gdb.  Documentation of kernel debugger is available

-- 

Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2007-09-28 12:28 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-19 12:23 2.6.23-rc6-mm1 powerpc - kgdb is broken Kamalesh Babulal
2007-09-19 18:53 ` Jason Wessel
2007-09-19 19:36   ` Andrew Morton
2007-09-20  5:23     ` Paul Mackerras
2007-09-20  5:53       ` Andrew Morton
2007-09-20  7:38       ` Christoph Hellwig
2007-09-28 10:37         ` Kamalesh Babulal
2007-09-28 10:47           ` Thomas Gleixner
2007-09-28 12:28             ` 2.6.23-rc6-mm1 powerpc - kgdb is broken [Resending PATCH] Kamalesh Babulal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox