Re: error from checkpatch.pl version 0.10

[Andy Whitcroft <apw@shadowen.org>]

On Thu, Sep 20, 2007 at 07:19:59PM +0530, Satyam Sharma wrote:
> 
> 
> On Thu, 20 Sep 2007, Tetsuo Handa wrote:
> > 
> > I checked my patch using checkpatch.pl version 0.10
> > and I got the following error.
> > 
> >   ERROR: need consistent spacing around '*' (ctx:WxV)
> >   #2334: FILE: security/tomoyo/common.c:2306:
> >   +static unsigned int tmy_poll(struct file *file, poll_table *wait)
> >                                                               ^
> 
> Looks like a checkpatch.pl bug to me -- that was nothing to warn about.

Hmm yeah this is a false positive, its hard to detect correctly.  Some
fool decided to use * as both a unary and binary operator and made life
very hard indeed.  Most kernel defined types end _t to aid recognition.
This one does no.  I may special case it.  Either way ignore its
moaning!

> > What action should I take?
> > Ignore this error because "poll_table" is used everywhere?
> > Replace "poll_table" with "struct poll_table_struct" according to
> > definition of "poll_table"?
> 
> Yeah, this would be better to do anyway (and rename poll_table_struct
> to just poll_table).
> 
> >   typedef struct poll_table_struct {
> >           poll_queue_proc qproc;
> >   } poll_table;
> 
> So:
> 
> 	struct poll_table {
> 		poll_queue_proc qproc;
> 	};
> 
> In general the kernel's codingstyle consensus is to avoid adding typedefs.

-apw