[PATCH 1/3] fix OOPS in platform uevent

[PATCH 1/3] fix OOPS in platform uevent

[Stephen Hemminger]

[-- Attachment #1: sysfs-oops.patch --]
[-- Type: text/plain, Size: 616 bytes --]

Environment wasn't being NULL terminated.
Suggested by Kay Sievers

Fixes: http://bugzilla.kernel.org/show_bug.cgi?id=9034

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>

--- a/drivers/base/platform.c	2007-06-25 09:03:10.000000000 -0700
+++ b/drivers/base/platform.c	2007-09-20 11:35:57.000000000 -0700
@@ -546,6 +546,7 @@ static int platform_uevent(struct device
 	struct platform_device	*pdev = to_platform_device(dev);
 
 	envp[0] = buffer;
+	envp[1] = NULL;
 	snprintf(buffer, buffer_size, "MODALIAS=%s", pdev->name);
 	return 0;
 }

-- 
Stephen Hemminger <shemminger@linux-foundation.org>

[PATCH 2/3] missing null termination in power supply uevent

[Stephen Hemminger]

[-- Attachment #1: sysfs-power.patch --]
[-- Type: text/plain, Size: 551 bytes --]

Need to null terminate environment. Found by inspection
while looking for similar problems to platform uevent bug

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>


--- a/drivers/power/power_supply_sysfs.c	2007-08-18 07:50:10.000000000 -0700
+++ b/drivers/power/power_supply_sysfs.c	2007-09-20 11:42:11.000000000 -0700
@@ -289,6 +289,7 @@ int power_supply_uevent(struct device *d
 		if (ret)
 			goto out;
 	}
+	envp[i] = NULL;
 
 out:
 	free_page((unsigned long)prop_buf);

-- 
Stephen Hemminger <shemminger@linux-foundation.org>

[PATCH 3/3] missing null termination in one wire uevent

[Stephen Hemminger]

[-- Attachment #1: sysfs-wl.patch --]
[-- Type: text/plain, Size: 621 bytes --]

Need to null terminate environment. Found by inspection
while looking for similar problems to platform uevent bug

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>

--- a/drivers/w1/w1.c	2007-08-18 07:50:12.000000000 -0700
+++ b/drivers/w1/w1.c	2007-09-20 11:44:06.000000000 -0700
@@ -431,6 +431,7 @@ static int w1_uevent(struct device *dev,
 	err = add_uevent_var(envp, num_envp, &cur_index, buffer, buffer_size,
 			&cur_len, "W1_SLAVE_ID=%024LX",
 			(unsigned long long)sl->reg_num.id);
+	envp[cur_index] = NULL;
 	if (err)
 		return err;
 

-- 
Stephen Hemminger <shemminger@linux-foundation.org>

Re: [PATCH 2/3] missing null termination in power supply uevent

[Anton Vorontsov]

On Thu, Sep 20, 2007 at 12:06:10PM -0700, Stephen Hemminger wrote:
> Need to null terminate environment. Found by inspection
> while looking for similar problems to platform uevent bug
> 
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>

Much thanks, git-applymbox'ed to battery-2.6.git. I suppose this is
serious enough, thus should hit 2.6.23.

Though prior asking to pull I'll wait just a bit.

Thanks,

-- 
Anton Vorontsov
email: cbou@mail.ru
backup email: ya-cbou@yandex.ru
irc://irc.freenode.net/bd2