From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Alexey Starikovskiy <aystarik@gmail.com>
Cc: Frans Pop <elendil@planet.nl>, Pavel Machek <pavel@ucw.cz>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Maciek Rutecki <maciej.rutecki@gmail.com>
Subject: Re: 2.6.23-rc6: S4 and S5 no longer listed as supported on Toshiba Satellite A40
Date: Thu, 20 Sep 2007 22:07:12 +0200 [thread overview]
Message-ID: <200709202207.13101.rjw@sisk.pl> (raw)
In-Reply-To: <46F2BD0D.2010206@gmail.com>
On Thursday, 20 September 2007 20:33, Alexey Starikovskiy wrote:
> Frans Pop wrote:
> > On Thursday 20 September 2007, you wrote:
> >> Please try this patch.
> >
> > Works. All states are now listed again.
> > I've not tested suspend to disk, but suspend to ram and power off work fine.
> >
> >> +printk(KERN_INFO PREFIX "(supports");
> >> #ifdef CONFIG_SUSPEND
> >> - printk(KERN_INFO PREFIX "(supports");
> >> for (i = ACPI_STATE_S0; i < ACPI_STATE_S4; i++) {
> >
> > Isn't there a risk now that we now end up printing
> > ACPI: (supports)
> > if CONFIG_SUSPEND is not enabled and >S4 is not supported?
> >
> > Or, more probably, it would print
> > ACPI: (supports S5)
> Don't know what does it mean to support S0 exactly... :)
> > as it is unlikely that "off" is not supported :-)
> >
> > Maybe S0 should be taken outside the #ifdef and the loop as that state is
> > also basically always there?
> Don't think it is worth the trouble. We already have this loop almost completely unrolled,
> let's not make it complete mess...
Well, you could use "(supports S0" instead of just "(supports". ;-)
Greetings,
Rafael
next prev parent reply other threads:[~2007-09-20 20:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 18:14 2.6.23-rc6: S4 and S5 no longer listed as supported on Toshiba Satellite A40 Frans Pop
2007-09-20 10:53 ` Pavel Machek
2007-09-20 12:37 ` Frans Pop
2007-09-20 16:01 ` Maciek Rutecki
2007-09-20 16:34 ` Alexey Starikovskiy
2007-09-20 20:01 ` Rafael J. Wysocki
2007-09-20 16:59 ` 2.6.23-rc6: S4 and S5 no longer listed as supported on ToshibaSatellite A40 Romano Giannetti
2007-09-20 16:33 ` 2.6.23-rc6: S4 and S5 no longer listed as supported on Toshiba Satellite A40 Frans Pop
2007-09-20 16:33 ` Maciek Rutecki
2007-09-20 17:29 ` Alexey Starikovskiy
2007-09-20 18:17 ` Frans Pop
2007-09-20 18:33 ` Alexey Starikovskiy
2007-09-20 20:07 ` Rafael J. Wysocki [this message]
2007-09-20 20:32 ` Frans Pop
2007-09-20 20:53 ` Rafael J. Wysocki
2007-09-21 14:04 ` Alexey Starikovskiy
2007-09-21 14:33 ` Rafael J. Wysocki
2007-09-20 21:18 ` Frans Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709202207.13101.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=aystarik@gmail.com \
--cc=elendil@planet.nl \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox