Re: 2.6.23-rc6-mm1

Mel Gorman
2007-09-24T11:15:12Z

On (22/09/07 14:11), Satyam Sharma didst pronounce:
>
> > -static volatile int kgdb_hwbreak_sstep[NR_CPUS];
> > +volatile int kgdb_hwbreak_sstep[NR_CPUS];
>
> That looks fishy to me. Why is it volatile-qualified?

It turned out that it was unnecessary. A follow-up patch removed the volatile
and kept the static.

> And does that
> actually want to be a per-cpu var?
>

--
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab