From: Steven Rostedt <rostedt@goodmis.org>
To: Gilboa Davara <gilboad@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Minor patch] Reduce __print_symbol/sprint_symbol stack usage.
Date: Fri, 21 Sep 2007 10:47:26 -0400 [thread overview]
Message-ID: <20070921144726.GD15697@goodmis.org> (raw)
In-Reply-To: <1189856129.18191.11.camel@gilboa-home-dev.localdomain>
On Sat, Sep 15, 2007 at 02:35:29PM +0300, Gilboa Davara wrote:
> - return sprintf(buffer, "%s+%#lx/%#lx", name, offset, size);
> + if (namebuf)
> + kfree(namebuf);
Note, the if condition is not needed, kfree handles null pointers fine.
-- Steve
next prev parent reply other threads:[~2007-09-21 14:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-15 11:35 [Minor patch] Reduce __print_symbol/sprint_symbol stack usage Gilboa Davara
2007-09-15 13:02 ` Satyam Sharma
2007-09-15 15:15 ` Gilboa Davara
2007-09-15 18:08 ` [PATCH] " Gilboa Davara
2007-09-19 1:00 ` Satyam Sharma
2007-09-19 14:25 ` Paulo Marques
2007-09-21 12:45 ` Gilboa Davara
2007-09-21 14:21 ` Paulo Marques
2007-09-21 14:57 ` Gilboa Davara
2007-09-21 14:56 ` Steven Rostedt
2007-09-21 15:47 ` Paulo Marques
2007-09-21 12:31 ` Gilboa Davara
2007-09-21 14:28 ` [PATCH] Reduce __print_symbol/sprint_symbol stack usage. (v3) Gilboa Davara
2007-09-21 16:02 ` Paulo Marques
2007-09-21 16:19 ` Gilboa Davara
2007-09-21 14:47 ` Steven Rostedt [this message]
2007-09-21 14:53 ` [Minor patch] Reduce __print_symbol/sprint_symbol stack usage Gilboa Davara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070921144726.GD15697@goodmis.org \
--to=rostedt@goodmis.org \
--cc=gilboad@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox