From: Greg KH <greg@kroah.com>
To: Werner Cornelius <Werner.Cornelius@cornelius-consult.de>
Cc: linux-kernel@vger.kernel.org, mtosatti@redhat.com
Subject: Re: [PATCH] Re: Serial USB-driver for Winchiphead CH340/41 chip
Date: Fri, 21 Sep 2007 09:18:50 -0700 [thread overview]
Message-ID: <20070921161850.GA11771@kroah.com> (raw)
In-Reply-To: <200709211015.11470.Werner.Cornelius@cornelius-consult.de>
On Fri, Sep 21, 2007 at 10:15:11AM +0200, Werner Cornelius wrote:
> Hello,
>
> attached you will find the patch against the 2.6.23-rc6-mm1
>
> Changed fetaures:
>
> 1. All baudrates possible (dynamic baudfactor calculation)
> 2. Added support of modem control and status lines.
You forgot:
3. broke all formatting
:(
Please redo the patch such that the formating of the file is not changed
(you converted tabs to spaces).
> --- linux-2.6.23-rc6-mm1/drivers/usb/serial/ch341.c 2007-09-21
> 09:56:56.000000000 +0200
> +++ develop/drivers/usb/serial/ch341.c 2007-09-21 10:00:26.000000000 +0200
> @@ -1,5 +1,9 @@
> /*
> - * Copyright 2007, Frank A Kingswood <frank@kingswood-consulting.co.uk>
> + * Copyright 2007, Frank A Kingswood <frank <at> kingswood-consulting.co.uk>
Why did you change this email address?
> + *
> + * Copyright 2007, Werner Cornelius <werner <at> cornelius-consult.de>
> + * for changes/extenions regarding universal baud rate capability and modem
> + * line control/status routines.
Don't put changelog information in a copyright notice, that's not
needed. Just put your name there please, with a "real" email address.
And we need a "Signed-off-by:" line.
thanks,
greg k-h
next prev parent reply other threads:[~2007-09-21 16:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-14 12:38 Serial USB-driver for Winchiphead CH340/41 chip Werner Cornelius
2007-09-20 0:03 ` Greg KH
2007-09-21 8:15 ` [PATCH] " Werner Cornelius
2007-09-21 8:36 ` Oliver Neukum
2007-09-21 16:18 ` Greg KH [this message]
2007-09-21 20:34 ` Werner Cornelius
2007-09-21 21:00 ` Greg KH
2007-09-21 11:06 ` Werner Cornelius
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070921161850.GA11771@kroah.com \
--to=greg@kroah.com \
--cc=Werner.Cornelius@cornelius-consult.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox