public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Fix printk levels in intel-rng
Date: Fri, 21 Sep 2007 18:14:27 -0400	[thread overview]
Message-ID: <20070921221427.GI11455@redhat.com> (raw)
In-Reply-To: <ada7imjy8sn.fsf@cisco.com>

On Fri, Sep 21, 2007 at 03:04:40PM -0700, Roland Dreier wrote:
 >  > [   41.250634] intel_rng: Firmware space is locked read-only. <4>intel_rng: If you can't or
 >  > [   41.250638]  don't want to <4>intel_rng: disable this in firmware setup, and <4>intel_rng: if
 >  > [   41.250639]  you are certain that your <4>intel_rng: system has a functional
 >  > [   41.250641]  RNG, try<4>intel_rng: using the 'no_fwh_detect' option.
 >  > [   41.250706] agpgart: AGP aperture is 128M @ 0xe8000000
 > 
 >  >  			KERN_WARNING PFX "Firmware space is locked read-only. If you can't or\n"
 >  > -			KERN_WARNING PFX "don't want to disable this in firmware setup, and if\n"
 >  > -			KERN_WARNING PFX "you are certain that your system has a functional\n"
 >  > -			KERN_WARNING PFX "RNG, try using the 'no_fwh_detect' option.\n";
 >  > +			PFX "don't want to disable this in firmware setup, and if\n"
 >  > +			PFX "you are certain that your system has a functional\n"
 >  > +			PFX "RNG, try using the 'no_fwh_detect' option.\n";
 > 
 > I think Alan already fixed this in f3dc8c18 -- notice that your
 > screwed-up message has the <4> after eg read-only, and the current
 > code doesn't line-wrap there.

Ah, was looking at a dmesg from an older kernel. Good catch.

Thanks,

	Dave

-- 
http://www.codemonkey.org.uk

      reply	other threads:[~2007-09-21 22:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-21 21:53 Fix printk levels in intel-rng Dave Jones
2007-09-21 22:04 ` Roland Dreier
2007-09-21 22:14   ` Dave Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070921221427.GI11455@redhat.com \
    --to=davej@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdreier@cisco.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox