public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "David J. Wilder" <dwilder@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [Patch 2/2] Relay reset consumend
Date: Sun, 23 Sep 2007 13:45:59 +0100	[thread overview]
Message-ID: <20070923124559.GA8064@infradead.org> (raw)
In-Reply-To: <1190177220.3190.19.camel@lc4eb748232119.ibm.com>

On Tue, Sep 18, 2007 at 09:46:59PM -0700, David J. Wilder wrote:
> This patch allows relay channels to be reset i.e. unconsumed.
> Basically allows a 'rewind' function for flight-recorder tracing.

This should be patch 1 because relay_reset_consumed is used by
the other patch.

> +/**
> + *	__relay_reset_consumed - reset a channel buffer's consumed count
> + *	@buf: the channel buffer
> + *
> + *	See relay_reset_consumed for description of effect.
> + */
> +static inline void __relay_reset_consumed(struct rchan_buf *buf)

Please don't mark functions explicitly inline unless needed.


      reply	other threads:[~2007-09-23 12:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-19  4:46 [Patch 2/2] Relay reset consumend David J. Wilder
2007-09-23 12:45 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070923124559.GA8064@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=dwilder@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox