public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Dave Jones <davej@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Arjan van de Ven <arjan@infradead.org>,
	Cyrill Gorcunov <gorcunov@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: memset as memzero
Date: Sun, 23 Sep 2007 13:07:50 -0300	[thread overview]
Message-ID: <20070923160750.GO4887@ghostprotocols.net> (raw)
In-Reply-To: <20070923153243.GE8127@redhat.com>

Em Sun, Sep 23, 2007 at 11:32:43AM -0400, Dave Jones escreveu:
> On Sat, Sep 22, 2007 at 11:53:53AM -0700, Linus Torvalds wrote:
>  > 
>  > 
>  > On Sat, 22 Sep 2007, Arjan van de Ven wrote:
>  > > 
>  > > it doesn't add value.... memset with a constant 0 is just as fast
>  > > (since the compiler knows it's 0) than any wrapper around it, and the
>  > > syntax around it is otherwise the same.
>  > 
>  > Indeed.
>  > 
>  > The reason we have "clear_page()" is not because the value we're writing 
>  > is constant - that doesn't really help/change anything at all. We could 
>  > have had a "fill_page()" that sets the value to any random byte, it's just 
>  > that zero is the only value that we really care about.
>  > 
>  > So the reason we have "clear_page()" is because the *size* and *alignment* 
>  > is constant and known at compile time, and unlike the value you write, 
>  > that actually matters.
>  > 
>  > So "memzero()" would never really make sense as anything but a syntactic 
>  > wrapper around "memset(x,0,size)". 
> 
> There is one useful argument for memzero (or bzero to give it its proper
> name), and that's that it's impossible to screw up.
> I'm still amazed at how many times I see
> 
> 	memset (x,size,0);
> 
> in various code. So much so, that my editor highlights it now to spot
> it during code review.  As does my mail client.  To be on the safe
> side, I also have a cron job grepping for it in my ~/Mail/commits
> for all the projects I'm interested in.
> 
> It's tragic really just how easy it is to screw it up.

bzero! That is it, its nothing new, just a sane name to something that
is useful to humans, even being of sheer arrogant disdain for machines
as a useless stuff only humans couldn't get right. Yeah, us screw up
pretty much more than them.

- Arnaldo

  reply	other threads:[~2007-09-23 16:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-22  8:33 memset as memzero Cyrill Gorcunov
2007-09-22  8:48 ` Robert P. J. Day
2007-09-22  9:35   ` Cyrill Gorcunov
2007-09-22  9:55     ` Robert P. J. Day
2007-09-22 10:15       ` Cyrill Gorcunov
2007-09-22 19:46 ` Arjan van de Ven
2007-09-22 18:53   ` Linus Torvalds
2007-09-23 15:32     ` Dave Jones
2007-09-23 16:07       ` Arnaldo Carvalho de Melo [this message]
2007-09-23 17:05         ` Linus Torvalds
2007-09-23 18:46           ` Willy Tarreau
2007-09-23 16:33       ` Robert P. J. Day
2007-09-23 16:46         ` Arnaldo Carvalho de Melo
2007-09-22 19:25   ` Bernd Eckenfels
2007-09-22 20:37     ` Oleg Verych (nntp)
2007-09-22 19:32   ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070923160750.GO4887@ghostprotocols.net \
    --to=acme@ghostprotocols.net \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=davej@redhat.com \
    --cc=gorcunov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox