* 2.6.23-rc7-mm1: r/o mounts joke with lockdep
@ 2007-09-24 9:51 Alexey Dobriyan
2007-09-24 16:26 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Dobriyan @ 2007-09-24 9:51 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, haveblue
static void lock_and_coalesce_cpu_mnt_writer_counts(void)
{
int cpu;
struct mnt_writer *cpu_writer;
for_each_possible_cpu(cpu) {
cpu_writer = &per_cpu(mnt_writers, cpu);
spin_lock_nested(&cpu_writer->lock, 42);
^^^^
What the heck is going on? Given that MAX_LOCKDEP_SUBCLASSES is only 8,
this reliably turns off lockdep at boot.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: 2.6.23-rc7-mm1: r/o mounts joke with lockdep
2007-09-24 9:51 2.6.23-rc7-mm1: r/o mounts joke with lockdep Alexey Dobriyan
@ 2007-09-24 16:26 ` Andrew Morton
2007-09-24 16:33 ` Dave Hansen
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2007-09-24 16:26 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: linux-kernel, haveblue
On Mon, 24 Sep 2007 13:51:05 +0400 Alexey Dobriyan <adobriyan@sw.ru> wrote:
> static void lock_and_coalesce_cpu_mnt_writer_counts(void)
> {
> int cpu;
> struct mnt_writer *cpu_writer;
>
> for_each_possible_cpu(cpu) {
> cpu_writer = &per_cpu(mnt_writers, cpu);
> spin_lock_nested(&cpu_writer->lock, 42);
> ^^^^
>
> What the heck is going on?
that was some random 2:00AM hack by me to make the warnings go away.
> Given that MAX_LOCKDEP_SUBCLASSES is only 8,
> this reliably turns off lockdep at boot.
that explains why it worked so well.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: 2.6.23-rc7-mm1: r/o mounts joke with lockdep
2007-09-24 16:26 ` Andrew Morton
@ 2007-09-24 16:33 ` Dave Hansen
0 siblings, 0 replies; 3+ messages in thread
From: Dave Hansen @ 2007-09-24 16:33 UTC (permalink / raw)
To: Andrew Morton; +Cc: Alexey Dobriyan, linux-kernel
On Mon, 2007-09-24 at 09:26 -0700, Andrew Morton wrote:
> On Mon, 24 Sep 2007 13:51:05 +0400 Alexey Dobriyan <adobriyan@sw.ru> wrote:
>
> > static void lock_and_coalesce_cpu_mnt_writer_counts(void)
> > {
> > int cpu;
> > struct mnt_writer *cpu_writer;
> >
> > for_each_possible_cpu(cpu) {
> > cpu_writer = &per_cpu(mnt_writers, cpu);
> > spin_lock_nested(&cpu_writer->lock, 42);
> > ^^^^
> >
> > What the heck is going on?
>
> that was some random 2:00AM hack by me to make the warnings go away.
>
> > Given that MAX_LOCKDEP_SUBCLASSES is only 8,
> > this reliably turns off lockdep at boot.
>
> that explains why it worked so well.
Arjan gave me some ideas on how to fix this more properly. I'm trying
to reproduce it and working on a patch now.
-- Dave
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-09-24 16:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-24 9:51 2.6.23-rc7-mm1: r/o mounts joke with lockdep Alexey Dobriyan
2007-09-24 16:26 ` Andrew Morton
2007-09-24 16:33 ` Dave Hansen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox