From: Jesse Barnes <jesse.barnes@intel.com>
To: "Vegard Nossum" <vegard.nossum@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
holzheu <holzheu@linux.vnet.ibm.com>,
"Joe Perches" <joe@perches.com>, "Rob Landley" <rob@landley.net>,
"Dick Streefland" <dick.streefland@altium.nl>
Subject: Re: [RFC] New kernel-message logging API
Date: Mon, 24 Sep 2007 11:26:39 -0700 [thread overview]
Message-ID: <200709241126.41375.jesse.barnes@intel.com> (raw)
In-Reply-To: <19f34abd0709221227v67443c0bg2cd2010e5bd5a6c1@mail.gmail.com>
On Saturday, September 22, 2007 12:27 pm Vegard Nossum wrote:
> enum kprint_loglevel {
> KPRINT_EMERG, /* kprint_emerg() */
> KPRINT_ALERT, /* kprint_alert() */
> KPRINT_CRIT, /* kprint_crit() */
> KPRINT_ERROR, /* kprint_error() and/or kprint_err() */
> KPRINT_WARNING, /* kprint_warning() and/or kprint_warn() */
> KPRINT_NOTICE, /* kprint_notice() */
> KPRINT_INFO, /* kprint_info() */
> KPRINT_DEBUG, /* kprint_debug() */
> };
I wonder if all these levels are still needed (though I really like the
error/err & warning/warn aliases, those always get me :).
It seems like fewer levels would make things easier on both kernel
developers and administrators; looking at current counts may help
figure out which ones could be combined (warning, very naive grep -r
data):
KERN_EMERG: 371
KERN_ALERT: 236
KERN_CRIT: 602
KERN_ERR: 11961
KERN_WARNING: 6463
KERN_NOTICE: 1142
KERN_INFO: 8491
KERN_DEBUG: 6125
So KERN_ERR is the most common by a pretty large margin, though it seems
to me that KERN_NOTICE, KERN_INFO and KERN_DEBUG are mostly redundant
and probably make up a majority of the "SIMD FPU exception support was
enabled" (as if I care) type messages. Likewise, ERR, ALERT, CRIT and
EMERG serve very similar purposes (i.e. something unrecoverable
occurred), maybe they could be condensed into one or two levels rather
than four? So that would drop us to three levels:
KERN_ERR /* something really bad happened, machine is dead or near so */
KERN_WARNING /* you really ought to know about this */
KERN_INFO /* no one but the kernel developer likely cares about this */
But maybe I'm just living in a dream world where then number of printks
the kernel spits out suddenly drops by 99% and only actually important
messages make it to my log...
Jesse
next prev parent reply other threads:[~2007-09-24 18:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-22 19:27 [RFC] New kernel-message logging API Vegard Nossum
2007-09-23 0:13 ` Joe Perches
2007-09-23 0:40 ` Kyle Moffett
2007-09-23 0:47 ` Joe Perches
2007-09-23 3:43 ` Kyle Moffett
2007-09-23 8:39 ` Vegard Nossum
2007-09-23 8:45 ` Jan Engelhardt
2007-09-23 9:20 ` Vegard Nossum
2007-09-23 9:38 ` Jan Engelhardt
2007-09-23 19:23 ` Joe Perches
2007-09-23 19:25 ` Joe Perches
2007-09-23 1:05 ` Miguel Ojeda
2007-09-25 5:27 ` Vegard Nossum
2007-09-25 17:24 ` Miguel Ojeda
2007-09-23 20:05 ` Rob Landley
2007-09-24 9:22 ` Michael Holzheu
2007-09-24 15:19 ` Joe Perches
2007-09-24 16:43 ` Vegard Nossum
2007-09-24 17:00 ` Joe Perches
2007-09-24 20:37 ` Vegard Nossum
2007-09-25 1:18 ` Rob Landley
2007-09-24 23:51 ` Rob Landley
2007-09-25 0:10 ` Joe Perches
2007-09-25 1:46 ` Rob Landley
2007-09-25 8:57 ` Michael Holzheu
2007-09-24 18:26 ` Jesse Barnes [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-09-25 4:58 linux
2007-09-25 6:54 ` Joe Perches
2007-09-25 7:50 ` linux
2007-09-25 8:06 ` Vegard Nossum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709241126.41375.jesse.barnes@intel.com \
--to=jesse.barnes@intel.com \
--cc=dick.streefland@altium.nl \
--cc=holzheu@linux.vnet.ibm.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rob@landley.net \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox