From: WANG Cong <xiyou.wangcong@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: roel <12o3l@tiscali.nl>,
linux-kernel@vger.kernel.org, bluez-devel@lists.sourceforge.net,
maxk@qualcomm.com, Marcel Holtmann <marcel@holtmann.org>
Subject: [-mm Patch] net/bluetooth/hidp/core.c: Make hidp_setup_input() return int
Date: Mon, 24 Sep 2007 19:30:35 +0800 [thread overview]
Message-ID: <20070924113035.GE2442@hacking> (raw)
In-Reply-To: <20070924021716.9bfe7dfb.akpm@linux-foundation.org>
This patch:
- makes hidp_setup_input() return int to indicate errors;
- checks its return value to handle errors.
And this time it is against -rc7-mm1 tree.
Thanks to roel and Marcel Holtmann for comments.
Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
---
net/bluetooth/hidp/core.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
Index: linux-2.6.23-rc7-mm1/net/bluetooth/hidp/core.c
===================================================================
--- linux-2.6.23-rc7-mm1.orig/net/bluetooth/hidp/core.c
+++ linux-2.6.23-rc7-mm1/net/bluetooth/hidp/core.c
@@ -625,7 +625,7 @@ static struct device *hidp_get_device(st
return conn ? &conn->dev : NULL;
}
-static inline void hidp_setup_input(struct hidp_session *session, struct hidp_connadd_req *req)
+static inline int hidp_setup_input(struct hidp_session *session, struct hidp_connadd_req *req)
{
struct input_dev *input = session->input;
int i;
@@ -669,7 +669,7 @@ static inline void hidp_setup_input(stru
input->event = hidp_input_event;
- input_register_device(input);
+ return input_register_device(input);
}
static int hidp_open(struct hid_device *hid)
@@ -822,8 +822,11 @@ int hidp_add_connection(struct hidp_conn
session->flags = req->flags & (1 << HIDP_BLUETOOTH_VENDOR_ID);
session->idle_to = req->idle_to;
- if (session->input)
- hidp_setup_input(session, req);
+ if (session->input) {
+ err = hidp_setup_input(session, req);
+ if (err < 0)
+ goto failed;
+ }
if (session->hid)
hidp_setup_hid(session, req);
next prev parent reply other threads:[~2007-09-24 11:35 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-24 9:17 2.6.23-rc7-mm1 Andrew Morton
2007-09-24 10:07 ` 2.6.23-rc7-mm1 Kamalesh Babulal
2007-09-24 21:02 ` 2.6.23-rc7-mm1 Sam Ravnborg
2007-09-24 21:36 ` 2.6.23-rc7-mm1 Sam Ravnborg
2007-09-24 23:27 ` 2.6.23-rc7-mm1 Kamalesh Babulal
2007-09-24 10:35 ` 2.6.23-rc7-mm1 - 'touch' command causes Oops Valdis.Kletnieks
2007-09-24 11:08 ` Balbir Singh
2007-09-24 12:05 ` Christoph Hellwig
2007-09-24 12:58 ` Valdis.Kletnieks
2007-09-24 15:45 ` Dave Hansen
2007-09-24 16:08 ` Valdis.Kletnieks
2007-09-24 11:30 ` WANG Cong [this message]
2007-09-24 22:18 ` [-mm Patch] net/bluetooth/hidp/core.c: Make hidp_setup_input() return int Marcel Holtmann
2007-09-26 5:57 ` David Miller
2007-09-24 11:42 ` 2.6.23-rc7-mm1 Kamalesh Babulal
2007-09-24 12:32 ` 2.6.23-rc7-mm1 -- s390 compile failures Andy Whitcroft
2007-09-24 12:49 ` Cedric Le Goater
2007-09-24 12:33 ` 2.6.23-rc7-mm1 Jiri Slaby
2007-09-24 14:41 ` [linux-usb-devel] 2.6.23-rc7-mm1 Alan Stern
2007-09-24 18:45 ` Jiri Slaby
2007-09-24 19:06 ` Alan Stern
2007-09-24 19:18 ` Jiri Slaby
2007-09-24 19:41 ` Alan Stern
2007-09-30 8:26 ` Jiri Slaby
2007-09-24 12:35 ` 2.6.23-rc7-mm1 -- powerpc rtas panic Andy Whitcroft
2007-10-02 23:28 ` Linas Vepstas
2007-10-03 0:26 ` Tony Breeds
2007-10-03 0:30 ` Michael Ellerman
2007-10-03 1:19 ` Tony Breeds
2007-10-03 4:09 ` Michael Ellerman
2007-10-03 18:50 ` Linas Vepstas
2007-10-05 0:01 ` Nish Aravamudan
2007-10-05 16:03 ` Linas Vepstas
2007-10-08 3:47 ` Nish Aravamudan
2007-09-24 12:47 ` 2.6.23-rc7-mm1 Cedric Le Goater
2007-09-24 16:56 ` 2.6.23-rc7-mm1 Jens Axboe
2007-09-24 12:55 ` 2.6.23-rc7-mm1 Kamalesh Babulal
2007-09-24 13:10 ` 2.6.23-rc7-mm1 Pavel Emelyanov
2007-09-24 13:21 ` 2.6.23-rc7-mm1 Balbir Singh
2007-09-24 15:34 ` 2.6.23-rc7-mm1 Pavel Emelyanov
2007-09-24 16:10 ` 2.6.23-rc7-mm1 Balbir Singh
2007-09-24 13:00 ` 2.6.23-rc7-mm1 Cedric Le Goater
2007-09-24 13:10 ` 2.6.23-rc7-mm1 Cedric Le Goater
2007-09-24 13:29 ` 2.6.23-rc7-mm1 Vlad Yasevich
2007-09-24 16:58 ` 2.6.23-rc7-mm1 Jens Axboe
2007-09-24 16:57 ` 2.6.23-rc7-mm1 Jens Axboe
2007-09-24 13:13 ` 2.6.23-rc7-mm1 Kamalesh Babulal
2007-09-24 16:44 ` 2.6.23-rc7-mm1 Andrew Morton
2007-09-24 16:57 ` 2.6.23-rc7-mm1 Peter Zijlstra
2007-09-24 17:08 ` 2.6.23-rc7-mm1 Kamalesh Babulal
2007-09-24 19:20 ` 2.6.23-rc7-mm1 Peter Zijlstra
2007-09-25 11:05 ` 2.6.23-rc7-mm1 Peter Zijlstra
2007-09-25 13:07 ` 2.6.23-rc7-mm1 Kamalesh Babulal
2007-09-24 13:17 ` [PATCH rc7-mm1] fix BUG at mm/swap.c:405! Hugh Dickins
2007-09-24 14:52 ` 2.6.23-rc7-mm1 Reuben Farrelly
2007-09-24 16:59 ` 2.6.23-rc7-mm1 Andrew Morton
2007-09-24 17:12 ` 2.6.23-rc7-mm1 J. Bruce Fields
2007-09-24 21:31 ` 2.6.23-rc7-mm1 Reuben Farrelly
2007-09-24 15:18 ` 2.6.23-rc7-mm1 ia64 build issue in efi.c Bob Picco
2007-09-24 19:07 ` 2.6.23-rc7-mm1 Torsten Kaiser
2007-09-24 19:34 ` 2.6.23-rc7-mm1 Andrew Morton
2007-09-24 20:25 ` 2.6.23-rc7-mm1 Thomas Gleixner
2007-09-25 7:32 ` 2.6.23-rc7-mm1 Torsten Kaiser
2007-09-25 7:44 ` 2.6.23-rc7-mm1 Thomas Gleixner
2007-09-24 19:41 ` 2.6.23-rc7-mm1 Kamalesh Babulal
2007-09-25 10:23 ` 2.6.23-rc7-mm1 Mel Gorman
2007-09-25 10:31 ` 2.6.23-rc7-mm1 Jens Axboe
2007-09-25 11:15 ` 2.6.23-rc7-mm1 Mel Gorman
2007-09-25 11:23 ` 2.6.23-rc7-mm1 Jens Axboe
2007-09-24 20:10 ` 2.6.23-rc7-mm1: build error with CONFIG_KEXEC=y and CONFIG_NOHIGHMEM=y Laurent Riffard
2007-09-24 23:11 ` Randy Dunlap
2007-09-24 22:20 ` 2.6.23-rc7-mm1 Kamalesh Babulal
-- strict thread matches above, loose matches on Subject: below --
2007-09-18 8:18 2.6.23-rc6-mm1 Andrew Morton
2007-09-23 3:01 ` [-mm Patch] net/bluetooth/hidp/core.c: Make hidp_setup_input() return int WANG Cong
2007-09-23 22:13 ` roel
2007-09-24 2:38 ` WANG Cong
2007-09-24 7:09 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070924113035.GE2442@hacking \
--to=xiyou.wangcong@gmail.com \
--cc=12o3l@tiscali.nl \
--cc=akpm@linux-foundation.org \
--cc=bluez-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=maxk@qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox