Re: [42/50] Fix ipv6 source address handling.

roel
2007-09-24T22:06:13Z

can't we also decrease the number of brackets here?

--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -1021,7 +1021,7 @@ int ipv6_dev_get_saddr(struct net_device
hiscore.rule++;
}
if (ipv6_saddr_preferred(score.addr_type) ||
- (((ifa_result->flags &
+ (((ifa->flags &
(IFA_F_DEPRECATED|IFA_F_OPTIMISTIC)) == 0))) {

make this like this
if (ipv6_saddr_preferred(score.addr_type) ||
(ifa->flags &
(IFA_F_DEPRECATED|IFA_F_OPTIMISTIC)) == 0) {

or even for clarity's sake:
if (ipv6_saddr_preferred(score.addr_type) ||
(ifa->flags & (IFA_F_DEPRECATED|IFA_F_OPTIMISTIC)) == 0) {