public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Dike <jdike@addtoit.com>
To: lepton <ytht.net@gmail.com>
Cc: lkm <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.6.22.6 user-mode linux: fix error in check_sysemu
Date: Mon, 24 Sep 2007 12:45:19 -0400	[thread overview]
Message-ID: <20070924164519.GB23078@c2.user-mode-linux.org> (raw)
In-Reply-To: <20070923122653.GA17386@router.lepton.home>

On Sun, Sep 23, 2007 at 08:26:53PM +0800, lepton wrote:
>   it is a error do count++ here, it will let the following compare
>(after 8 lines)   " if (!count)" always be false.

> -		count++;

Have you booted a UML with this change?  It looks to me like you'll
just make it crash on boot every time.

Something is wrong here, but ripping out that one line doesn't look
like the fix.

				Jeff

-- 
Work email - jdike at linux dot intel dot com

  reply	other threads:[~2007-09-24 16:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-23 12:26 [PATCH] 2.6.22.6 user-mode linux: fix error in check_sysemu lepton
2007-09-24 16:45 ` Jeff Dike [this message]
2007-09-24 16:52 ` Jeff Dike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070924164519.GB23078@c2.user-mode-linux.org \
    --to=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ytht.net@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox