Re: [PATCH 3/5] Cleanup code under CONFIG_FAIR_GROUP_SCHED

Randy Dunlap
2007-09-24T16:55:46Z

On Mon, 24 Sep 2007 22:09:37 +0530 Srivatsa Vaddagiri wrote:

> With the view of supporting user-id based fair scheduling (and not just
> container-based fair scheduling), this patch renames several functions
> and makes them independent of whether they are being used for container
> or user-id based fair scheduling.
>
> Also fix a problem reported by KAMEZAWA Hiroyuki (wrt allocating
> less-sized array for tg->cfs_rq[] and tf->se[]).
>
>
> Signed-off-by : Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
> Signed-off-by : Dhaval Giani <dhaval@linux.vnet.ibm.com>
>
>
> ---
> include/linux/sched.h | 12 +++
> init/Kconfig | 11 +--
> kernel/sched.c | 172 ++++++++++++++++++--------------------------------
> kernel/sched_fair.c | 5 +
> 4 files changed, 83 insertions(+), 117 deletions(-)
>
> Index: current/init/Kconfig
> ===================================================================
> --- current.orig/init/Kconfig
> +++ current/init/Kconfig
> @@ -282,13 +282,12 @@ config CPUSETS
> Say N if unsure.
>
> config FAIR_GROUP_SCHED
> - bool "Fair group scheduler"
> - depends on EXPERIMENTAL && CONTAINERS
> + bool "Fair group cpu scheduler"

Can we have "CPU" instead of "cpu" ?

> + default n
> + depends on EXPERIMENTAL
> help
> - This option enables you to group tasks and control CPU resource
> - allocation to such groups.
> -
> - Say N if unsure.
> + This feature lets cpu scheduler recognize task groups and control cpu
> + bandwidth allocation to such task groups.
>
> config SYSFS_DEPRECATED
> bool "Create deprecated sysfs files"

---
~Randy
Phaedrus says that Quality is about caring.