From: Dave Jones <davej@redhat.com>
To: Jonathan Campbell <jon@nerdgrounds.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Patches for tiny 386 kernels, again. Linux kernel 2.6.22.7
Date: Mon, 24 Sep 2007 15:09:17 -0400 [thread overview]
Message-ID: <20070924190917.GG8127@redhat.com> (raw)
In-Reply-To: <46F77A85.6020202@nerdgrounds.com>
On Mon, Sep 24, 2007 at 01:51:17AM -0700, Jonathan Campbell wrote:
> +#if defined(__i386__) && defined(CONFIG_DMI)
> dmi_check_system(acpi_dmi_table);
> #endif
>
> +#ifdef CONFIG_DMI
> dmi_scan_machine();
> +#endif
>
> +#ifdef CONFIG_DMI
> /* Check and install the TSC clocksource */
> dmi_check_system(bad_tsc_dmi_table);
> +#endif
>
> +#ifdef CONFIG_DMI
> dmi_check_system(acpi_osl_dmi_table);
> +#endif
Instead of adding all these ifdefs, we could just define
add something along the lines of..
#ifndef CONFIG_DMI
#define dmi_check_system do {} while (0)
#endif
in some header, which hides the uglies away from the code
whilst having the same net effect.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-09-24 19:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-24 8:51 [PATCH] Patches for tiny 386 kernels, again. Linux kernel 2.6.22.7 Jonathan Campbell
2007-09-24 17:49 ` Randy Dunlap
2007-09-26 18:42 ` Jonathan Campbell
2007-09-26 22:06 ` Randy Dunlap
2007-09-26 23:20 ` Randy Dunlap
2007-09-26 23:44 ` Jonathan Campbell
[not found] ` <46FAEE97.7090902@nerdgrounds.com>
2007-09-26 23:47 ` Randy Dunlap
2007-09-26 23:49 ` Jonathan Campbell
2007-09-28 21:24 ` Bill Davidsen
2007-09-28 21:56 ` Randy Dunlap
2007-10-01 13:44 ` Lennart Sorensen
2007-10-01 14:28 ` Bill Davidsen
2007-10-02 4:48 ` Willy Tarreau
2007-09-24 19:09 ` Dave Jones [this message]
2007-09-25 4:45 ` Andrey Panin
2007-09-25 7:28 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070924190917.GG8127@redhat.com \
--to=davej@redhat.com \
--cc=jon@nerdgrounds.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox