From: Bernhard Walle <bwalle@suse.de>
To: akpm@linux-foundation.org
Cc: Laurent Riffard <laurent.riffard@free.fr>, linux-kernel@vger.kernel.org
Subject: [PATCH] Fix CONFIG_NOHIGHMEM for extended crashkernel command line
Date: Tue, 25 Sep 2007 08:55:29 +0200 [thread overview]
Message-ID: <20070925065528.GA25783@suse.de> (raw)
This patch fixes a build error with CONFIG_KEXEC=y and CONFIG_NOHIGHMEM=y.
linux-2.6-mm$ LANG=C make
CHK include/linux/version.h
CHK include/linux/utsrelease.h
CALL scripts/checksyscalls.sh
CHK include/linux/compile.h
CC arch/i386/kernel/setup.o
arch/i386/kernel/setup.c: In function 'reserve_crashkernel':
arch/i386/kernel/setup.c:391: error: 'highend_pfn' undeclared (first use in this function)
arch/i386/kernel/setup.c:391: error: (Each undeclared identifier is reported only once
arch/i386/kernel/setup.c:391: error: for each function it appears in.)
arch/i386/kernel/setup.c:391: error: 'highstart_pfn' undeclared (first use in this function)
make[1]: *** [arch/i386/kernel/setup.o] Error 1
make: *** [arch/i386/kernel] Error 2
Signed-off-by: Bernhard Walle <bwalle@suse.de>
---
arch/i386/kernel/setup.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
--- a/arch/i386/kernel/setup.c
+++ b/arch/i386/kernel/setup.c
@@ -381,6 +381,20 @@ extern unsigned long __init setup_memory
extern void zone_sizes_init(void);
#endif /* !CONFIG_NEED_MULTIPLE_NODES */
+
+#ifdef CONFIG_HIGHMEM
+static inline unsigned long long get_total_mem(void)
+{
+ return (max_low_pfn + highend_pfn - highstart_pfn) << PAGE_SHIFT;
+}
+#else
+static inline unsigned long long get_total_mem(void)
+{
+ return max_low_pfn << PAGE_SHIFT;
+}
+#endif
+
+
#ifdef CONFIG_KEXEC
static void __init reserve_crashkernel(void)
{
@@ -388,7 +402,7 @@ static void __init reserve_crashkernel(v
unsigned long long crash_size, crash_base;
int ret;
- free_mem = (max_low_pfn + highend_pfn - highstart_pfn) << PAGE_SHIFT;
+ free_mem = get_total_mem();
ret = parse_crashkernel(boot_command_line, free_mem,
&crash_size, &crash_base);
next reply other threads:[~2007-09-25 6:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 6:55 Bernhard Walle [this message]
2007-09-25 7:06 ` [PATCH] Fix CONFIG_NOHIGHMEM for extended crashkernel command line Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070925065528.GA25783@suse.de \
--to=bwalle@suse.de \
--cc=akpm@linux-foundation.org \
--cc=laurent.riffard@free.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox