Re: [RFC/PATCH -v2] Add sysfs control to modify a user's cpu share

Ingo Molnar
2007-10-04T07:58:20Z

* Dhaval Giani <dhaval@linux.vnet.ibm.com> wrote:

> Hi Ingo,
>
> Can you please drop commit b1add858a10cece3a68b2d8cb9e7350843700a58 (last
> version of this patch) and try this instead?

> Changelog since v1:
> 1. Added a mutex to serialize directory creation/destruction for a user in
> sysfs
> 2. Added a spinlock in the task_group structure to serialize writes to
> tg->shares.
> 3. Removed /proc/root_user_cpu_shares.
> 4. Added Documentation about the group scheduler.

thanks - I have added this to the queue.

i'm wondering about the following: could not (yet) existing UIDs be made
configurable too? I.e. if i do this in a bootup script:

echo 2048 > /sys/kernel/uids/500/cpu_share

this should just work too, regardless of there not being any UID 500
tasks yet. Likewise, once configured, the /sys/kernel/uids/* directories
(with the settings in them) should probably not go away either.

Ingo