From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@suse.de>, Takashi Iwai <tiwai@suse.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.23-rc8-mm1, -rc7-mm1 kill audio on HP nx6325
Date: Tue, 25 Sep 2007 15:20:09 +0200 [thread overview]
Message-ID: <200709251520.09794.rjw@sisk.pl> (raw)
In-Reply-To: <1190722710.4035.320.camel@chaos>
On Tuesday, 25 September 2007 14:18, Thomas Gleixner wrote:
> On Tue, 2007-09-25 at 14:08 +0200, Rafael J. Wysocki wrote:
> > Hi,
> >
> > This patch from Andi:
> >
> > x86_64-mm-cpa-einval.patch
> >
> > makes the hda_intel audio driver stop working on my HP nx6325.
> >
> > The following line appears in dmesg (from 2.6.23-rc7-mm1:
> >
> > ALSA /home/rafael/src/mm/linux-2.6.23-rc7-mm1/sound/pci/hda/hda_intel.c:1755: hd
> > a-intel: ioremap error
> >
> > and the driver doesn't work afterwards.
> >
> > Still, I'm not sure if the patch above is wrong or rather it exposes a problem
> > in the driver.
>
> The patch is correct. Instead of returning "Success" in the case of a
> failure of lookup_address, it now returns -EINVAL, which in turn makes
> the ioremap fail.
>
> OTOH, the driver ioremap call looks straight forward. Can you apply the
> patch below and provide the resulting debug output please ?
lookup failed for 18446604438082158592
[--snipped some USB messages--]
ALSA /home/rafael/src/mm/linux-2.6.23-rc8-mm1/sound/pci/hda/hda_intel.c:1756: hda-intel: ioremap error: 2349334528 16384
Greetings,
Rafael
next prev parent reply other threads:[~2007-09-25 13:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 12:08 2.6.23-rc8-mm1, -rc7-mm1 kill audio on HP nx6325 Rafael J. Wysocki
2007-09-25 12:18 ` Thomas Gleixner
2007-09-25 13:20 ` Rafael J. Wysocki [this message]
2007-09-25 13:44 ` Thomas Gleixner
2007-09-25 14:29 ` Rafael J. Wysocki
2007-09-25 14:35 ` Thomas Gleixner
[not found] <200709251353.52723.rjw@sisk.pl>
2007-09-25 16:08 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709251520.09794.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox