Re: [patch 3/5] Add samples subdir

[Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>]

* Randy Dunlap (randy.dunlap@oracle.com) wrote:
> On Tue, 25 Sep 2007 21:00:36 +0200 Sam Ravnborg wrote:
> 
> Hi Sam,
> 
> Thanks for looking.  I was hoping that you would find time to
> look/comment on it.
> 
> > Hi Mathieu & Randy.
> > 
> > On Tue, Sep 25, 2007 at 08:11:48AM -0400, Mathieu Desnoyers wrote:
> > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > > 
> > > Begin infrastructure for kernel code samples in the samples/ directory.
> > > Add its Kconfig and Kbuild files.
> > > Source its Kconfig file in all arch/ Kconfigs.
> > 
> > Sorry for not commenting on this before...
> > The samples directory contains sample code so it is wrong to actually
> > include it as part of the kernel IMHO.
> > We only want to keep the samples buildable and to do so
> > we can make a much simpler hack in the top-level Makefile.
> > Consider following patch:
> > 
> > @@ -760,6 +760,9 @@ vmlinux: $(vmlinux-lds) $(vmlinux-init) $(vmlinux-main) $(kallsyms.o) vmlinux.o
> >  ifdef CONFIG_HEADERS_CHECK
> >         $(Q)$(MAKE) -f $(srctree)/Makefile headers_check
> >  endif
> > +ifdef CONFIG_SAMPLES
> > +       $(Q)$(MAKE) $(build)=samples
> > +endif
> >         $(call vmlinux-modpost)
> >         $(call if_changed_rule,vmlinux__)
> >         $(Q)rm -f .old_version
> > 
> > 
> > With this we build the samples when CONFIG_SAMPLES are selected and
> > when the kernel is about to be linked.
> > 
> > 
> > As for the Kconfig file I am in favour of it but think a much more
> > natural place is to source it in lib/Kconfig.debug.
> > Then it will appear in "Kernel hacking" and the smaples
> > are used for kernel hacking and not for regular people
> > building their own kernel.
> > 
> > Sourcing samples/Kconfig from lib/Kconfig.debug will then
> > take effect for all archs so the result is a much simpler
> > Kconfig patch too.
> 
> These changes all sound good to me.
> 
> Mathieu, can you find time to do this or should I do it?
> 

I'll take care of it.

> ---
> ~Randy
> Phaedrus says that Quality is about caring.

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68