Re: ACPI power off regression in 2.6.23-rc8 (NOT in rc7)

Rafael J. Wysocki
2007-09-25T15:46:18Z

On Tuesday, 25 September 2007 17:40, Linus Torvalds wrote:
>
> On Tue, 25 Sep 2007 08:51:09 +0200 Damien Wyart <damien.wyart@free.fr> wrote:
> >
> > Hello,
> >
> > After testing rc8, I noticed that I couldn't power off the computer
> > directly, it only got halted and I had to press the power button
> > manually. Just before displaying "System halted", the following message
> > is displayed:
> >
> > ACPI : PCI interrupt for device 0000:02:08.0 disabled
> >
> > I had to first revert 5a50fe709d527f31169263e36601dd83446d5744 then
> > f216cc3748a3a22c2b99390fddcdafa0583791a2 (handling of Sx states) to
> > recover previous behaviour.
>
> Hmm. Those things *do* seem to be suspicious.
>
> For example, those commits seem to move code that used to be inside
> CONFIG_PM (which pretty much *everybody* has) to be inside
> CONFIG_ACPI_SLEEP (which is a totally different thing, and depends on
> whether the user asked for suspend support or not!
>
> Damien - does it work if you ask for SUSPEND or HIBERNATION support?
>
> Len - why are you guys moving stuff into CONFIG_PM_SLEEP? I know you seem
> to think that absolutely *everybody* should always support suspend and
> hibernation, but the fact is, not everybody does. And it's a totally
> separate thing for normal ACPI CPU runstate support that people have used
> to manage a *running* CPU (and shutting it down).

This was a mistake and fixes have already been posted:

http://marc.info/?l=linux-acpi&m=119052970904643&w=4
http://marc.info/?l=linux-acpi&m=119073173625910&w=4

Greetings,
Rafael