Re: [PATCH 4/4] sysfs: make suicidal nodes just do it directly

Tejun Heo
2007-09-20T09:44:19Z

Cornelia Huck wrote:
> On Thu, 20 Sep 2007 16:26:15 +0900,
> Tejun Heo <htejun@gmail.com> wrote:
>
>> Sysfs now allows direct suicide. Make suicidial sysfs nodes to use
>> it and remove now unncessary callback mechanism.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>> ---
>> drivers/base/core.c | 33 ----------------------
>> drivers/s390/cio/ccwgroup.c | 25 +++-------------
>> drivers/scsi/scsi_sysfs.c | 13 +--------
>> fs/sysfs/file.c | 63 -------------------------------------------
>> include/linux/device.h | 6 ----
>> include/linux/sysfs.h | 9 ------
>> 6 files changed, 6 insertions(+), 143 deletions(-)
>>
>
> Just browsing through this (I'll review and do some tests later), but
> you missed drivers/s390/cio/device.c::ccw_device_remove_disconnected().
>
> Following (not event compile tested) patch (which is basically a revert
> of 59a8a6e227cf0bc42e5be741ebfea97c222ab9ef) should take care of it.
>
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>

Thanks for spotting this. After converting ccwgroup, I thought that was
it for s390.

--
tejun