Re: [PATCH 1/4] module: implement module_inhibit_unload()

Tejun Heo
2007-09-25T14:07:23Z

Rusty Russell wrote:
> On Tue, 2007-09-25 at 17:36 +0900, Tejun Heo wrote:
>> Hmmm.... There doesn't seem to any reason why the blocking should be
>> after calling ->exit(). And, yeah, it would be more useful and
>> intuitive if blocking happens before ->exit(). What do you think?
>
> *That* I have no problem with.
>
> I was going to say "just grab a reference to every module" except if a
> new module is loaded you don't know about it.
>
> If you move your blocking, it seems fine.

Great, I think I was too occupied with the sysfs case when I was writing
it. I'll update the patch. Thanks a lot.

--
tejun