From: Chris Snook <csnook@redhat.com>
To: akpm@linux-foundation.org
Cc: andi@firstfloor.org, linux-kernel@vger.kernel.org
Subject: [PATCH RESEND] x86_64: make atomic64_t work like atomic_t
Date: Wed, 26 Sep 2007 02:36:54 -0400 [thread overview]
Message-ID: <20070926063654.GA11773@shell.boston.redhat.com> (raw)
Regardless of the greater controversy about the semantics of atomic_t, I think
we can all agree that atomic_t and atomic64_t should have the same semantics.
This is presently not the case on x86_64, where the volatile keyword was
removed from the declaration of atomic_t, but it was not removed from the
declaration of atomic64_t. The following patch fixes that inconsistency,
without delving into anything more controversial.
From: Chris Snook <csnook@redhat.com>
The volatile keyword has already been removed from the declaration of atomic_t
on x86_64. For consistency, remove it from atomic64_t as well.
Signed-off-by: Chris Snook <csnook@redhat.com>
CC: Andi Kleen <andi@firstfloor.org>
--- a/include/asm-x86_64/atomic.h 2007-07-08 19:32:17.000000000 -0400
+++ b/include/asm-x86_64/atomic.h 2007-09-13 11:30:51.000000000 -0400
@@ -206,7 +206,7 @@ static __inline__ int atomic_sub_return(
/* An 64bit atomic type */
-typedef struct { volatile long counter; } atomic64_t;
+typedef struct { long counter; } atomic64_t;
#define ATOMIC64_INIT(i) { (i) }
reply other threads:[~2007-09-26 6:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070926063654.GA11773@shell.boston.redhat.com \
--to=csnook@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox