public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH RESEND] x86_64: make atomic64_t work like atomic_t
@ 2007-09-26  6:36 Chris Snook
  0 siblings, 0 replies; only message in thread
From: Chris Snook @ 2007-09-26  6:36 UTC (permalink / raw)
  To: akpm; +Cc: andi, linux-kernel

Regardless of the greater controversy about the semantics of atomic_t, I think
we can all agree that atomic_t and atomic64_t should have the same semantics.
This is presently not the case on x86_64, where the volatile keyword was
removed from the declaration of atomic_t, but it was not removed from the
declaration of atomic64_t.  The following patch fixes that inconsistency,
without delving into anything more controversial.

From: Chris Snook <csnook@redhat.com>

The volatile keyword has already been removed from the declaration of atomic_t
on x86_64.  For consistency, remove it from atomic64_t as well.

Signed-off-by: Chris Snook <csnook@redhat.com>
CC: Andi Kleen <andi@firstfloor.org>

--- a/include/asm-x86_64/atomic.h	2007-07-08 19:32:17.000000000 -0400
+++ b/include/asm-x86_64/atomic.h	2007-09-13 11:30:51.000000000 -0400
@@ -206,7 +206,7 @@ static __inline__ int atomic_sub_return(
 
 /* An 64bit atomic type */
 
-typedef struct { volatile long counter; } atomic64_t;
+typedef struct { long counter; } atomic64_t;
 
 #define ATOMIC64_INIT(i)	{ (i) }
 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-09-26  6:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-26  6:36 [PATCH RESEND] x86_64: make atomic64_t work like atomic_t Chris Snook

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox